Re: Use -fcommon with or remove security/siphon

On Mon, 1 Feb 2021 02:34:53 +0100
Klemens Nanni <kn@openbsd.org> wrote:

> Upstream still ships the tarball, that's it,
> "primary distsite and homepage have gone away" in 2002 as per CVS log.
>
> The only TCP port I've been able to detect (after producing traffing
> on a variety of them) is SSH -- and that only worked after enabling
> IPv4.
>
> Siphon does not seem to support/detect IPv6 at all and it's OS
> fingerprints are extremely old; with Gentoo we're the only ones still
> packaging it according to Repology.
>
> I tend to simply remove it (ports tree house keeping), but here's a
> diff to "fix" the port in case anyone actually finds it useful.
>
> OK either for removal or the diff?

OK cwen@ to remove.

> ---
> Set "-fcommon" for twelve duplicate symbols.
>
> Regen patch and add "@bin" PLIST marker while here.
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/security/siphon/Makefile,v
> retrieving revision 1.16
> diff -u -p -r1.16 Makefile
> --- Makefile 12 Jul 2019 20:49:36 -0000 1.16
> +++ Makefile 1 Feb 2021 01:13:10 -0000
> @@ -4,7 +4,7 @@ COMMENT= passive network mapping tool
>
> DISTNAME= siphon-v.666
> PKGNAME= siphon-0.666
> -REVISION= 0
> +REVISION= 1
> CATEGORIES= security net
>
> # BSD-style
> @@ -22,6 +22,9 @@ MAKE_FLAGS= CC="${CC}" \
> MAKE_ENV= SYSCONFDIR="${SYSCONFDIR}"
>
> NO_TEST= Yes
> +
> +# twelve duplicate symbols
> +CFLAGS += -fcommon
>
> do-install:
> ${INSTALL_PROGRAM} ${WRKSRC}/siphon ${PREFIX}/bin
> Index: patches/patch-log_c
> ===================================================================
> RCS file: /cvs/ports/security/siphon/patches/patch-log_c,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 patch-log_c
> --- patches/patch-log_c 16 Jun 2001 14:56:26 -0000
> 1.1.1.1 +++ patches/patch-log_c 1 Feb 2021 01:12:32 -0000
> @@ -1,7 +1,8 @@
> $OpenBSD: patch-log_c,v 1.1.1.1 2001/06/16 14:56:26 lebel Exp $
> ---- log.c.orig Fri Jun 15 18:36:47 2001
> -+++ log.c Fri Jun 15 18:36:55 2001
> -@@ -137,7 +137,7 @@ char *oslookup(int window, int ttl, int
> +Index: log.c
> +--- log.c.orig
> ++++ log.c
> +@@ -137,7 +137,7 @@ char *oslookup(int window, int ttl, int df)
> FILE *osprints;
> static char line[80], *oswin, *osttl, *osdf, *os, hexed[10];
> static int check = 0;
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/security/siphon/pkg/PLIST,v
> retrieving revision 1.4
> diff -u -p -r1.4 PLIST
> --- pkg/PLIST 24 Sep 2004 09:37:39 -0000 1.4
> +++ pkg/PLIST 1 Feb 2021 01:13:24 -0000
> @@ -1,5 +1,5 @@
> @comment $OpenBSD: PLIST,v 1.4 2004/09/24 09:37:39 espie Exp $
> -bin/siphon
> +@bin bin/siphon
> share/doc/siphon/
> share/doc/siphon/LICENSE
> share/doc/siphon/README
>