Friday, February 26, 2021

Carriage returns in patch files

Patch files should not have MS-DOS line endings "\r\n".

I have cleaned up most instanced in the ports tree, removed the
carriage return characters, and listed the files to be patched in
FIX_CRLF_FILES.

Two ports remain:

* devel/sdl-pango
This applies a distpatch to a file with \r\n line endings.
Since FIX_CRLF_FILES is run before distpatch, it's not clear how
to handle this.

* misc/posixtestsuite
There are 250 patch files that need to be fixed. Listing them
all in FIX_CRLF_FILES doesn't seem appropriate. Blindly removing
trailing \r's from thousands of source files doesn't either. What
can we do?

--
Christian "naddy" Weisgerber naddy@mips.inka.de

No comments:

Post a Comment