Re: [Maintainer Update] databases/leveldb: 1.22 -> 1.23

Stuart Henderson <stu@spacehopper.org> writes:

> They haven't built tarballs themselves to distribute, but are relying on
> github auto-generating them. These don't include submodules (because
> git-archive doesn't include them).

Ah, that makes sense. I had wondered if it was an oversight on their
part, but they may not know about this (clearly I didn't).

> I think it's not that much of a problem, they're mostly just going to
> expect people running tests to get the code from a git checkout. Which
> for the most part is going to be true.

I guess. The problem is, even downloading the archive they have and
running cmake with the default options will result in configuration
errors - the test suite is on by default. I opened a ticket for them to
let them know about that, as it may confuse people who expect the build
to "just work".

> To use them in the port you can fetch them separately.. If there are a
> few you can use something like this:
>
> DISTFILES = ${DISTNAME}${EXTRACT_SUFX}
> .for A N C in \
> account1 name2 hash2 \
> account2 name2 hash2 \
> ...
> DISTFILES += $N-{$A/$N/archive/}$C.tar.gz:0
> .endfor
> MASTER_SITES0= https://github.com/
>
> then move them into the right dir e.g. in do-extract.

Does ports support a git checkout? Or is the only way to do this with a
tarball?

> ack, I think that's alright for now.

Thanks for the help, Stuart.

Cheers,

Ash