Sunday, February 28, 2021

Re: [PATCH 4/7] Use devel/cabal module for x11/xmonad (still the latest release)

Hi Greg,

On Thu, Feb 25, 2021 at 08:16:02PM -0800, Greg Steuck wrote:
[...]
> diff --git a/x11/xmonad/files/xmonad-config.cabal b/x11/xmonad/files/xmonad-config.cabal
> new file mode 100644
> index 00000000000..7615dd89677
> --- /dev/null
> +++ b/x11/xmonad/files/xmonad-config.cabal
> @@ -0,0 +1,13 @@
> +cabal-version: 2.4
> +
> +name: xmonad-config
> +version: 0.1.0.0
> +synopsis: XMonad config
> +author: Greg Steuck
> +maintainer: xmonad@nest.cx
> +
> +executable xmonad-config
> + main-is: xmonad.hs
> + build-depends: base, xmonad, data-default, xmonad-contrib
> + hs-source-dirs: .
> + default-language: Haskell2010

I think this also needs containers as a dependency, at least when
you use the sample xmonad.hs (which imports Data.Map).

I also wonder wether we should install xmonad.hs in
share/examples/xmonad-0.15, because you need all three files when
starting with the sample configuration. Alternatively, build and
xmonad-config.cabal could go into share/doc/xmonad. BTW: I wasn't
aware that xmonad also looks for ~/.xmonad/build when trying to
rebuild itself.

Finally, a x11/xmonad,-main marker should be added to the PLIST,
adn we will need a quirk for the removal of xmonad-lib.

Otherwise, ok.

Ciao,
Kili

No comments:

Post a Comment