Sunday, February 28, 2021

Re: [PATCH 4/7] Use devel/cabal module for x11/xmonad (still the latest release)

Hi Matthias,

Matthias Kilian <kili@outback.escape.de> writes:

>> +executable xmonad-config
>> + main-is: xmonad.hs
>> + build-depends: base, xmonad, data-default, xmonad-contrib
>> + hs-source-dirs: .
>> + default-language: Haskell2010
>
> I think this also needs containers as a dependency, at least when
> you use the sample xmonad.hs (which imports Data.Map).

Done. Also removed data-default which has long been replaced by
Data.Monoid's mempty.

> I also wonder wether we should install xmonad.hs in
> share/examples/xmonad-0.15, because you need all three files when
> starting with the sample configuration.

Great idea. I put them all into examples.

> Alternatively, build and xmonad-config.cabal could go into
> share/doc/xmonad. BTW: I wasn't aware that xmonad also looks for
> ~/.xmonad/build when trying to rebuild itself.

This only became practical after cabal-v2 and stack took over.

> Finally, a x11/xmonad,-main marker should be added to the PLIST,
> adn we will need a quirk for the removal of xmonad-lib.

Done, with help from sthen@ and espie@.

Thanks
Greg

No comments:

Post a Comment