Re: Remove audio/xhippo

On Sun, Jan 31, 2021 at 11:00:13PM +0100, Klemens Nanni wrote:
> Upstream at https://www.gnu.org/software/xhippo/ no longer provides
> distfiles since at least 2019, FreeBSD also has marked the port as such;
> the website says
>
> The GNU xhippo has been decommissioned.
>
> I think we should stop carrying such cruft.
>
> Other ports such as audio/mkplaylist do similar jobs, most media players
> also have such functionality, e.g. VLC does.

https://repology.org/project/xhippo/versions says HP-UX, OpenBSD, pkgsrc
and Rosalinux are the only ones packaging it.

Here's a fix, but I still prefer retiring the port.

OK/Objections for the two options?


Index: Makefile
===================================================================
RCS file: /cvs/ports/audio/xhippo/Makefile,v
retrieving revision 1.44
diff -u -p -r1.44 Makefile
--- Makefile 12 Jul 2019 21:02:13 -0000 1.44
+++ Makefile 3 Feb 2021 13:55:18 -0000
@@ -4,7 +4,7 @@ COMMENT= generic playlist manager for UN

DISTNAME= xhippo-3.5
CATEGORIES= audio
-REVISION = 5
+REVISION = 6

HOMEPAGE= https://www.gnu.org/software/xhippo/

Index: patches/patch-xhippo_h
===================================================================
RCS file: patches/patch-xhippo_h
diff -N patches/patch-xhippo_h
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-xhippo_h 4 Feb 2021 17:23:25 -0000
@@ -0,0 +1,16 @@
+$OpenBSD$
+
+Fix "-fno-common" build.
+
+Index: xhippo.h
+--- xhippo.h.orig
++++ xhippo.h
+@@ -182,7 +182,7 @@ extern guint contextid,
+ extern gint last_played,
+ last_row_hit,
+ last_row_clicked;
+-fileaction *last_action;
++extern fileaction *last_action;
+
+ /* Configuration options */
+ extern gboolean mode_play_on_start,