Re: graphics/piglit: missing BDEP on glslang

On Tue, Mar 30, 2021 at 07:58:10AM +0200, Theo Buehler wrote:
> piglit failed to build in a bulk due to a missing dependency. Patch
> below fixed the build for me.
>
> [3320/4182] cd /tmp/pobj/piglit-20210128/build-amd64/target_api/gl/tests/spec/ext_external_objects && /usr/local/bin/glslangValidator -V /tmp/pobj/piglit-20210128/piglit-83173d9536c9f5e1571efe5933d210466ec255b8/tests/spec/ext_external_objects/vk_blue.vert -o /tmp/pobj/piglit-20210128/piglit-83173d9536c9f5e1571efe5933d210466ec255b8/tests/spec/ext_external_objects/vk_blue.vert.spv
> FAILED: /tmp/pobj/piglit-20210128/piglit-83173d9536c9f5e1571efe5933d210466ec255b8/tests/spec/ext_external_objects/vk_blue.vert.spv
> cd /tmp/pobj/piglit-20210128/build-amd64/target_api/gl/tests/spec/ext_external_objects && /usr/local/bin/glslangValidator -V /tmp/pobj/piglit-20210128/piglit-83173d9536c9f5e1571efe5933d210466ec255b8/tests/spec/ext_external_objects/vk_blue.vert -o /tmp/pobj/piglit-20210128/piglit-83173d9536c9f5e1571efe5933d210466ec255b8/tests/spec/ext_external_objects/vk_blue.vert.spv
> /bin/sh: /usr/local/bin/glslangValidator: not found
> ninja: build stopped: subcommand failed.
> *** Error 1 in graphics/piglit (/usr/ports/devel/cmake/cmake.port.mk:36 'do-build': @cd /tmp/pobj/piglit-20210128/build-amd64 && exec /usr/b...)
> *** Error 2 in graphics/piglit (/usr/ports/infrastructure/mk/bsd.port.mk:2943 '/tmp/pobj/piglit-20210128/build-amd64/.build_done': @cd /usr/...)
> *** Error 2 in graphics/piglit (/usr/ports/infrastructure/mk/bsd.port.mk:2602 'build': @lock=piglit-20210128; export _LOCKS_HELD=" piglit-2...)
> ===> Exiting graphics/piglit with an error
> *** Error 1 in /usr/ports (infrastructure/mk/bsd.port.subdir.mk:137 'build': @: ${echo_msg:=echo}; : ${target:=build}; for i in ; do eval...

ok jsg@ though there is something odd here as there is a build time
check for it before it is used:

https://github.com/mesa3d/piglit/blob/83173d9536c9f5e1571efe5933d210466ec255b8/tests/spec/ext_external_objects/CMakeLists.gl.txt#L36

>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/graphics/piglit/Makefile,v
> retrieving revision 1.15
> diff -u -p -r1.15 Makefile
> --- Makefile 23 Feb 2021 19:39:26 -0000 1.15
> +++ Makefile 30 Mar 2021 05:18:57 -0000
> @@ -8,6 +8,7 @@ DISTNAME = piglit-20210128
> GH_ACCOUNT = mesa3d
> GH_PROJECT = piglit
> GH_COMMIT = 83173d9536c9f5e1571efe5933d210466ec255b8
> +REVISION = 0
>
> CATEGORIES = graphics
>
> @@ -37,6 +38,7 @@ RUN_DEPENDS = devel/py-six${MODPY_FLAVO
> math/py-numpy${MODPY_FLAVOR} \
> www/py-mako${MODPY_FLAVOR}
> BUILD_DEPENDS = ${RUN_DEPENDS} \
> + graphics/glslang \
> graphics/vulkan-headers
>
> LIB_DEPENDS = graphics/waffle \
>
>