Sunday, March 28, 2021

Re: shells/nsh

Hi All,
as a humble nsh user, I would like to have a go at trying to help with
this port,

we used it in the past and when we reported bugs Chris had resolved them,

I would humbly ask that it not be removed, and Im willing to (try) to see
if I can work through nsh bugs

the idea of nsh is brilliant ...


PS im interested in trying to help out with fastnetmon port also
Thanks
Tom Smyth


On Thu, 25 Mar 2021 at 09:12, Marc Espie <espie@nerim.net> wrote:

> I've looked a bit at this code.
>
> I'm on the fence between marking it as BROKEN and give Chris a chance to
> fix the code, or downright removing it.
>
> Specifically, it's currently broken thanks to recent changes to if.h,
> but the code warns all over the place. There seems to be a misconception
> that '\0' would be a NULL pointer (it's not, it's a character constant).
>
> Looking a bit deeper, clang finds at least one actual bug and some
> seriously confused code (strlcpy with size from the src instead of the
> dest,
> which is kind-of okay in this case because it is the same size, but still).
>
> I don't know who actually uses nsh, but I wouldn't recommend it in its
> present state... After all, you're running code as root, it should at
> least
> keep the warnings down... and it's not like we moved to clang two days
> ago.
>
>
> --
> Marc
>
>

--
Kindest regards,
Tom Smyth.

No comments:

Post a Comment