Re: UPDATE: comms/xastir to 2.1.6

On Thu, Mar 04, 2021 at 11:16:37AM +0100, Landry Breuil wrote:
> On Wed, Mar 03, 2021 at 10:48:40PM +0100, Michael wrote:
> > On Tue, Mar 02, 2021 at 05:06:45PM +0100, Landry Breuil wrote:
> > > On Tue, Mar 02, 2021 at 04:07:52PM +0100, Michael wrote:
> > > > On Tue, Mar 02, 2021 at 03:48:00PM +0100, Landry Breuil wrote:
> > > > > [...]
> > > > > can you check that it builds without the
> > > > > -DACCEPT_USE_OF_DEPRECATED_PROJ_API_H=1 in CFLAGS ? according to
> > > > > https://github.com/Xastir/Xastir/issues/47 that shouldnt be needed
> > > > > anymore, and a devel/proj update will remove proj_api.h.
> > > > >
> > > > > Landry
> > > > >
> > > >
> > > > Hello Landry,
> > > >
> > > > you are right, this is no longer needed.
> > > > Builds and runs fine without it, updated diff below.
> > >
> > > Thanks, that's great news ! I have zero knowledge about amateur radio,
> > > nor if this software works or not, but i'll definitely like the update
> > > so that i have one less hurdle to update proj !
> > >
> > > Landry
> > >
> >
> > The most basic things should work. Internet connectivity with common
> > servers such as aprs2.net also works well. It would be interesting to
> > get a report of somone using a serial connected GPS device since there
> > are OpenBSD specific patches for this in the port. But I don't think
> > this is critical. Also one could interface with gpsd too. Apart from
> > that I did not encounter any problems yet so I consider this program
> > well-functioning.
> >
> > If someone tries this port I recommend getting better map files as
> > discussed here: https://github.com/Xastir/Xastir/issues/152
>
> trying to build your diff with proj 8.0 installed, i get this configure output:
> ...
> checking for pj_init in -lproj... no
> ...
> *** Warning: geotiff requires libproj.
> ...
> configure: WARNING: unrecognized options: --with-pcre, --with-dbfawk,
> --with-rtree, --disable-gtk-doc
>
> MINIMUM OPTIONS:
> ShapeLib (Vector maps) .................... : yes
>
> RECOMMENDED OPTIONS:
> Xpm / Snapshots ........................... : yes
> GraphicsMagick/ImageMagick (Raster maps) .. : yes (GraphicsMagick)
> pcre (Shapefile customization) ............ : yes
> Berkeley DB map caching-Raster map speedups : yes
> internet map retrieval .................... : yes (libcurl)
>
> FOR THE ADVENTUROUS:
> AX25 (Linux Kernel I/O Drivers) ........... : no
> libproj (USGS Topos & Aerial Photos) ...... : no
> GeoTiff (USGS Topos & Aerial Photos) ...... : no
> Festival (Text-to-speech) ................. : no
> GPSMan/gpsmanshp (GPS downloads) .......... : no
>
> and port-lib-depends-check says that it didnt link against those libs:
> xastir-2.1.6(comms/xastir):
> Extra: gdal.40 geotiff.3 iconv.7 proj.16 tiff.40
>
> Can you recheck this on your install, so that i know if its local due to
> my testing of proj 8.0 ?

Ah, i looked a bit more, and its been reported/fixed upstream with
https://github.com/Xastir/Xastir/commit/6ee6348ca9ad8556e48d26d976f5d6709e8e31cb
cf https://github.com/Xastir/Xastir/issues/173

so i know where to look when i update proj, your diff should be totally
fine with proj 7.0.

Landry