You need i3 only if you want to use i3 module. You can just omit it in
your config file if you're not using i3.
So, for sure I should add i3 as a build dependency. But as installing
polybar doesn't install i3 as a run dependency, I don't see why we
should split the program in 2 separate packages.
Le 27/02/2021 à 13:03, Jasper Lievisse Adriaanse a écrit :
> On Tue, Feb 23, 2021 at 10:41:39AM +0100, Guy Godfroy wrote:
>> Hello,
>>
>> Thanks to recent py-sphinx update, here is the diff to update polybar.
>>
>> On the old version of the port, i3 support was explicitly disabled,
>> don't know why. I re-enabled it and it works fine.
>
> It was clearly stated in the commit message of -r1.4 at the time actually:
>
> "disable i3 support for now; it gets picked up during configure (though we had no BDEP on it)
> and I don't think it's worthwhile yet to force i3 as a dependency of polybar. we can still
> add an -i3 subpackage if there is a request for it."
>
> Your latest diff does work, though I still see no point in enabling i3 support for the sake
> of enabling it. If i3 support is much desired, please make it a subpackage to prevent
> forcing that dependency on those who use polybar with a different wm.
>
> For now I've committed your update, thanks.
>
> Cheers,
> Jasper
>
No comments:
Post a Comment