Sunday, March 07, 2021

x11/pmenu:

Without this the debug package is useless as it does not contain any
symbols; build the port with and without the diff and note the
addition of `-g' in cc(1) lines.

I don't need the debug package or DEBUG at all right now but noticed
the lack of `-O2 -pipe' when building this port.

Fix DESCR grammar while here; I'm mailing the diff instead of
committing it right away because I'm not sure if we want to deal this
way with broken CFLAGS.

Jerome, would you mind poking upstream about the CFLAGS handling in
config.mk? If they'd simply use `CFLAGS += ...' in this file to append
their stuff as needed, we could simply drop all the quirks in our
MAKE_FLAGS and build the port with our framework's defaults, e.g. CFLAGS
being honoured as passed through the environment, I think.


Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/pmenu/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile 4 Mar 2021 22:46:21 -0000 1.1.1.1
+++ Makefile 7 Mar 2021 18:50:50 -0000
@@ -5,6 +5,7 @@ COMMENT = contextual radial menu for X11
GH_ACCOUNT = phillbush
GH_PROJECT = pmenu
GH_TAGNAME = v2.2.0
+REVISION = 0

CATEGORIES = x11

@@ -25,6 +26,12 @@ NO_TEST = Yes

MAKE_FLAGS = FREETYPEINC=${X11BASE}/include/freetype2 \
MANPREFIX=${PREFIX}/man
+
+# ${WRKSRC}/config.mk ignores the environment, i.e. it should append to
+# (`+=') not set (`=') variables.
+# XXX CPPFLAGS is empty added to the end; abuse it to avoid patches and pass
+# CFLAGS such that DEBUG is honoured as required for DEBUG_PACKAGES to work.
+MAKE_FLAGS += CPPFLAGS='${CFLAGS}'

post-install:
${INSTALL_DATA_DIR} ${PREFIX}/share/examples/pmenu
Index: pkg/DESCR
===================================================================
RCS file: /cvs/ports/x11/pmenu/pkg/DESCR,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 DESCR
--- pkg/DESCR 4 Mar 2021 22:46:21 -0000 1.1.1.1
+++ pkg/DESCR 7 Mar 2021 18:36:33 -0000
@@ -1,6 +1,7 @@
-piemenu is a pie menu utility for X. It receives a menu specification OD
+piemenu is a pie menu utility for X. It receives a menu specification
in stdin, shows a menu for the user to select one of the options,
and outputs the option selected to stdout.
+
Features include radial Submenus (some pie-menu slices can spawn another
-menu), Icons (pie-menu slices can contain icon image),X resources support
-and Root window mode
+menu), Icons (pie-menu slices can contain icon image), X resources support
+and Root window mode.

No comments:

Post a Comment