Re: [NEW] net/Vger

Florian Viehweger <openbsd@out-of-creativity.de> writes:

> Hi,
>
>> > Out of curiosity, this personal preference? According to the
>> > documentation[1] it should be no longer than 80 chars.
>>
>> It's only for cosmetic purpose, it should not be longer
>> than 80 chars doesn't mean you can't have less per line.
>>
>> Your DESCR is absolutely not wrong here, but looks better
>> with a smaller column size.
>
> thanks for clarification. I don't mind having 80 chars in DESCR, but
> also no problem with 60.
>
> Updated port attached and user.list.diff for convenience.

Apologies for coming late to the party.

The port builds and seems to run fine here. It also passes portcheck,
port-lib-depends-check and make test.

The only thing I believe could be improved before importing is the
README, which is a bit odd IMHO. I'm attaching an updated tarball with
my proposal for the README, but in short

* the indentation of the relayd.conf excerpt is a bit odd
* it's a personal preference but I prefer ----8<---- over the
indentation for the examples.
* command meant to be run with root privileges are usually prefixed
with a '#' rather than a '$'
* I believe that the bit regarding the firewall configuration is
unnecessary because 1) it's not needed to run vger and 2) is anyway
redundant since the relayd example already shows the port 1965 is
binded. (also, why the `log connection'? It's useful, but not
strictly required) Maybe a note regarding the difference between
11965 and 1965 can be added.
* I also dropped the last paragraph of the readme, since that is already
explained well in the manpage, and it's another bit of info that needs
to be kept is sync with future version (eventually.)

English is not my mother tongue so please double-check that I'm not
adding errors; but you can also ignore this proposal and keep the
current README, it's fine either the way for me.

Cheers,

Omar Polo