On 5/2/2021 4:29 AM, Landry Breuil wrote:
> Le Sat, Apr 10, 2021 at 07:29:06PM -0400, Brad Smith a écrit :
>> On 4/10/2021 3:05 AM, Landry Breuil wrote:
>>> On Fri, Apr 09, 2021 at 04:53:17PM +0200, Landry Breuil wrote:
>>>> On Thu, Apr 08, 2021 at 06:19:58PM +0200, Jeroen Derks wrote:
>>>>> On 08/04/2021 14:35, Landry Breuil wrote:>
>>>>>> well that's very nice, definitely interested in those freebsd patches !
>>>>>> not 100% sure those will get in 6.9 though as we're slowly moving towards
>>>>>> lock, but send them anyway, and we'll figure out what we can do from
>>>>>> there. I suppose those come from https://github.com/aborche/qemu-guest-agent ?
>>>>> Indeed, here they are (if there's interest I can also send a diff of the patches
>>>>> compared to the FreeBSD patches to see what I've done):
>>>> oh, well that looks nice. A bit rought around the edges imo, and im not
>>>> sure we want to maintain a rather large patch like this in the
>>>> portstree. according to https://wiki.qemu.org/Contribute/SubmitAPatch i
>>>> think it should be pushed upstream, do you have any idea if the original
>>>> freebsd patches were proposed there or qemu-devel list ?
>>>>
>>>> i'll let brad decide, but as is this doesnt apply as-is against 6.0 rcs
>>>> which we're testing for post-6.9....
>>> so i've backported your patch on top of brad's 6.0rc2 qemu update, and
>>> fixed things here and there, removed commented code, and yeah get-vcpus,
>>> get-fsinfo and network-get-interfaces seems to work fine !
>> Thanks.
>>
>> I don't mind keeping this or some variation on it around. It is small
>> enough.
> here's a new patch below, with the patches massaged for qemu 6.0.
>
>> I would very much hope that there is an attempt to upstream this in some
>> form.
> i had filed https://github.com/aborche/qemu-guest-agent/issues/18 in the
> freebsd patches repo, guess at that point one just needs to polish the
> patches against qemu git master and send patches to qemu-devel..
>
> i might get there at some point :)
>
> Landry
Go ahead.
No comments:
Post a Comment