Re: [NEW] www/py-adblock

On Wed, Jun 02, 2021 at 07:35:40AM +0000, Kurt Mosiejczuk wrote:
> On Tue, Jun 01, 2021 at 08:19:00PM +0100, Stuart Henderson wrote:
>
> > > > That doesn't change anything, TEST_DEPENDS isn't needed as they're
> > > > already in BUILD_DEPENDS and you can't test without building.
> > > > Anyway; tests still fail but runtime works.
>
> > > > These are OK sthen@ to import
>
> > Would anyone like to import with my OK, or give me an OK for these?
>
> Only problem I see with py-adblock has "FLAVOR ?= python3" where it
> should have "FLAVOR = python3". It is also missing a TEST_DEPENDS on
> textproc/py-toml. Other than that? ok kmos to import
>
> Maturin looks alright. ok kmos to import
>
> --Kurt
>
Reattached with the above changes.

regards,
Dimitri
> >
> > > Changed the test cmd so it directly calls the pytest module.
> > > This should work. PYTHONPATH not required anymore since the module will
> > > be installed in the tests dir itself during do-test.
> > >
> > > All tests pass.
> > >
> > > -TEST_ENV = PYTHONPATH=${WRKSRC}${MODPY_SITEPKG}:${MODPY_SITEPKG}
> > > -
> > > do-build:
> > > ${MODCARGO_CARGO_RUN} build \
> > > --manifest-path ${MODCARGO_CARGOTOML} \
> > > @@ -108,10 +106,10 @@ do-build:
> > >
> > > do-test:
> > > pip${MODPY_VERSION} install --isolated \
> > > - --root=${WRKSRC} \
> > > + --target=${WRKSRC}/tests \
> > > --ignore-installed \
> > > --no-deps ${WRKSRC}/target/wheels/*.whl
> > > - cd ${MODPY_TEST_DIR} && ${SETENV} ${ALL_TEST_ENV} py.test -v
> > > + cd ${WRKSRC} && ${SETENV} ${ALL_TEST_ENV} ${MODPY_BIN} -m pytest -v
> >
> >
> >