Saturday, June 12, 2021

Re: [sparc64/base-gcc] Fix build of audio/mpg123

Kurt Mosiejczuk:

> The most recent version of mpg123 uses C99 for loop initialization.

It already did before.

The issue here is that upstream changed configure.ac to be compatible
with autoconf 2.71, then went back and used 2.69.

* With 2.71, AC_PROG_CC tries to enable C89/C99/C11 and AC_PROG_CC_C99
is a nop.
* With 2.69, AC_PROG_CC only tries to enable C89 and you need to use
AC_PROG_CC_C99 to get C99.

I prefer to let the configure script handle this as intended.
OK?

Index: Makefile
===================================================================
RCS file: /cvs/ports/audio/mpg123/Makefile,v
retrieving revision 1.107
diff -u -p -r1.107 Makefile
--- Makefile 11 Jun 2021 20:55:07 -0000 1.107
+++ Makefile 12 Jun 2021 21:12:56 -0000
@@ -20,7 +20,8 @@ EXTRACT_SUFX= .tar.bz2

WANTLIB= c m sndio

-CONFIGURE_STYLE=gnu
+AUTOCONF_VERSION=2.69
+CONFIGURE_STYLE=autoconf
CONFIGURE_ARGS= --enable-static \
--disable-lfs-alias \
--with-audio=sndio \
Index: patches/patch-configure_ac
===================================================================
RCS file: patches/patch-configure_ac
diff -N patches/patch-configure_ac
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-configure_ac 12 Jun 2021 21:12:56 -0000
@@ -0,0 +1,15 @@
+$OpenBSD$
+
+With autoconf 2.69, AC_PROG_CC only enables C89.
+
+Index: configure.ac
+--- configure.ac.orig
++++ configure.ac
+@@ -105,6 +105,7 @@ fi
+ AM_PROG_AS
+ dnl We really mean C99 here. The specific macro for that is gone.
+ AC_PROG_CC
++AC_PROG_CC_C99
+ AM_PROG_CC_C_O
+ AC_PROG_CPP
+ AC_PROG_INSTALL
--
Christian "naddy" Weisgerber naddy@mips.inka.de

No comments:

Post a Comment