Wednesday, June 02, 2021

Re: Update to minio-0.20210527

Le Tue, Jun 01, 2021 at 11:29:13AM -0400, Daniel Jakots a écrit :
> On Mon, 31 May 2021 22:22:40 -0400, Daniel Jakots <danj@chown.me> wrote:
>
> > Hi,
> >
> > I tried to update net/minio/server, I thought I would first share what
> > I did, and then I'll look at the client (since I've less interest in
> > it).
> >
> > What I did: go to
> > https://proxy.golang.org/github.com/minio/minio/@v/v0.0.0-20210101000000-89bb9f17d738.info
> > (the 12 "trailing" letters are the 12 first letters from the commit),
> > get the "(expected 20210527203804)" and use it in the Makefile (the
> > famous Denis method ;)).
> >
> > I thought it would be nice to switch to modules.inc so I ran `make
> > modgo-gen-modules > modules.inc`, took inspiration from
> > audio/navidrome/Makefile to see how to 'properly' include it.
> >
> > I removed the relevant MODGO_ lines from the Makefile and then built
> > it.
> >
> > Did I miss anything?
>
> I wrote
> https://github.com/danieljakots/obsd-ports-tools/blob/master/go-ports-var.go
> regarding the variables V and CID. It's most likely minio-specific but
> feel free to add support for other ports if you need such a thing as
> well (but don't break it for minio :p)
>
> Both projects switched to AGPLv3+
> https://github.com/minio/minio/commit/069432566fcfac1f1053677cc925ddafd750730a
> https://github.com/minio/mc/commit/1402987ccbb9877e15d865a110a21a9518ec9e44
>
> I updated the server part of the port on my machine, it seems to work
> fine.
>
> Here's a diff (attached instead of inline because it's > 500kB) that
> also updates the client.
>
> Comments? OK?
>

It looks good to me. OK denis@

No comments:

Post a Comment