On Fri, July 9, 2021 13:44, Jeremie Courreges-Anglas wrote:
> On Fri, Jul 09 2021, Stuart Henderson <stu@spacehopper.org> wrote:
>> On 2021/07/09 12:17, Jeremie Courreges-Anglas wrote:
>>>
>>> Hi,
>>>
>>> when trying to build editors/emacs,no_x11 I noticed that cmake (and
>>> thus python) were needed to build jansson. That's a bit much in my
>>> book. It turns out that upstream jansson seems to advertize ./configure
>>> instead of cmake. Also:
>>> - the autotools build provides shared and static libs by default, no
>>> need for a patch
>>> - the autotools build uses -Wl,--version-script thus the list of
>>> exported symbols shrinks a lot, which avoids potential conflicts with
>>> other libraries
>>>
>>> Looking for oks. The cmake files aren't installed anymore, I'll try to
>>> find out whether that's a problem.
>>
>> The ports using jansson which themselves are built with cmake are
>> logswan and fs2open; both builds are happy with this change.
>> This change makes sense and is OK with me.
>
> Thank you Stuart! Kirby, are you ok with this proposal?
>
Hi,
Looks good to me.
No comments:
Post a Comment