Re: [macppc / lld] Unbreak sysutils/gdmap

On Fri, 27 Aug 2021 15:18:14 +0000
Charlene Wendling <julianaito@posteo.jp> wrote:

> Hi,
>
> > https://bin.charlenew.xyz/gdmap-0.8.1p5.log
>
> Once again, macppc needs the `-lm' linker flag.
>
> With the below diff i can build gdmap [0] on macppc. While here, i've
> refreshed WANTLIB.
>
> The runtime has been tested successfully on macppc and amd64.
>
> Comments/feedback are welcome,
>
> Charlène.

ok gkoehler@

You put -lm before *.o in the link command. This back reference might
break some old linkers, but seems to work for us. (It's a backref
because the *.o calling sqrt is after the -lm providing sqrt.)

--George

> [0] https://bin.charlenew.xyz/gdmap_fixed.log
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/sysutils/gdmap/Makefile,v
> retrieving revision 1.9
> diff -u -p -u -p -r1.9 Makefile
> --- Makefile 12 Jul 2019 20:49:43 -0000 1.9
> +++ Makefile 27 Aug 2021 15:14:19 -0000
> @@ -3,17 +3,18 @@
> COMMENT = graphical disk map
> DISTNAME = gdmap-0.8.1
> CATEGORIES = sysutils x11
> -REVISION = 5
> +REVISION = 6
>
> HOMEPAGE = http://gdmap.sourceforge.net/
>
> # GPLv2
> PERMIT_PACKAGE = Yes
>
> -WANTLIB = X11 Xcomposite Xcursor Xdamage Xext Xfixes Xi Xinerama Xrandr
> -WANTLIB += Xrender atk-1.0 c cairo fontconfig freetype gdk-x11-2.0
> -WANTLIB += gdk_pixbuf-2.0 gio-2.0 glib-2.0 gobject-2.0 gtk-x11-2.0 iconv
> -WANTLIB += intl m pango-1.0 pangocairo-1.0 pangoft2-1.0 pthread xml2 z
> +WANTLIB += X11 Xcomposite Xcursor Xdamage Xext Xfixes Xi Xinerama
> +WANTLIB += Xrandr Xrender atk-1.0 c cairo fontconfig freetype
> +WANTLIB += gdk-x11-2.0 gdk_pixbuf-2.0 gio-2.0 glib-2.0 gobject-2.0
> +WANTLIB += gtk-x11-2.0 harfbuzz intl m pango-1.0 pangocairo-1.0
> +WANTLIB += pangoft2-1.0 pthread xml2 z
>
> MASTER_SITES = ${MASTER_SITE_SOURCEFORGE:=gdmap/}
>
> @@ -29,6 +30,6 @@ CONFIGURE_STYLE = autoconf
> AUTOCONF_VERSION = 2.61
>
> CONFIGURE_ENV = CPPFLAGS="-I${LOCALBASE}/include" \
> - LDFLAGS="-L${LOCALBASE}/lib"
> + LDFLAGS="-L${LOCALBASE}/lib -lm"
>
> .include <bsd.port.mk>
>


--
George Koehler <kernigh@gmail.com>