Re: [MAINTAINER UPDATE] www/qutebrowser -> 2.3.1

Dimitri Karamazov wrote:
> On Thu, Aug 26, 2021 at 05:03:52PM +0000, Dimitri Karamazov wrote:
> > Simple update for www/qutebrowser to 2.3.1
> >
> > Changelog:https://www.qutebrowser.org/doc/changelog.html
> >
> > Build & Run tested on amd64

Same here. Builds and runs and passes the usual checks on amd64.

Have you ever attempted to make the test suite run? It fails currently.

The test suite sais tox should be used. But also with tox, it fails
to run, but differently.

I tested with:

+TEST_DEPENDS = devel/py-tox${MODPY_FLAVOR}
+
+do-test:
+ cd ${WRKSRC} && tox

And got:
[500 lines of output that looks okay]
creating '.tox/dist/qutebrowser-2.3.1.zip' and adding 'qutebrowser-2.3.1' to it
adding 'qutebrowser-2.3.1'
adding 'qutebrowser-2.3.1/doc'
adding 'qutebrowser-2.3.1/icons'
adding 'qutebrowser-2.3.1/misc'
adding 'qutebrowser-2.3.1/qutebrowser'
adding 'qutebrowser-2.3.1/qutebrowser.egg-info'
adding 'qutebrowser-2.3.1/scripts'
adding 'qutebrowser-2.3.1/tests'
Traceback (most recent call last):
File "setup.py", line 68, in <module>
setuptools.setup(
File "/usr/local/lib/python3.8/site-packages/setuptools/__init__.py", line 153, in setup
return distutils.core.setup(**attrs)
File "/usr/local/lib/python3.8/distutils/core.py", line 148, in setup
dist.run_commands()
File "/usr/local/lib/python3.8/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/usr/local/lib/python3.8/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/usr/local/lib/python3.8/site-packages/setuptools/command/sdist.py", line 52, in run
self.make_distribution()
File "/usr/local/lib/python3.8/site-packages/setuptools/command/sdist.py", line 76, in make_distribution
orig.sdist.make_distribution(self)
File "/usr/local/lib/python3.8/distutils/command/sdist.py", line 480, in make_distribution
file = self.make_archive(base_name, fmt, base_dir=base_dir,
File "/usr/local/lib/python3.8/distutils/cmd.py", line 369, in make_archive
return archive_util.make_archive(base_name, format, root_dir, base_dir,
File "/usr/local/lib/python3.8/distutils/archive_util.py", line 250, in make_archive
filename = func(base_name, base_dir, **kwargs)
File "/usr/local/lib/python3.8/distutils/archive_util.py", line 182, in make_zipfile
zip.write(path, path)
File "/usr/local/lib/python3.8/zipfile.py", line 1741, in write
zinfo = ZipInfo.from_file(filename, arcname,
File "/usr/local/lib/python3.8/zipfile.py", line 539, in from_file
zinfo = cls(arcname, date_time)
File "/usr/local/lib/python3.8/zipfile.py", line 362, in __init__
raise ValueError('ZIP does not support timestamps before 1980')
ValueError: ZIP does not support timestamps before 1980

ERROR: FAIL could not package project - v = InvocationError('/usr/local/bin/python3.8 /usr/ports/pobj/qutebrowser-2.3.1/qutebrowser-2.3.1/setup.py sdist --formats=zip --dist-dir /usr/ports/pobj/qutebrowser-2.3.1/qutebrowser-2.3.1/.tox/dist (see /usr/ports/pobj/qutebrowser-2.3.1/qutebrowser-2.3.1/.tox/log/tox-0.log)', 1)
*** Error 2 in . (Makefile:33 'do-test')
*** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2976 '/usr/ports/pobj/qutebrowser-2.3.1/.test_done': @cd /usr/ports/www/qutebrows...)
*** Error 2 in /usr/ports/www/qutebrowser (/usr/ports/infrastructure/mk/bsd.port.mk:2602 'test': @lock=qutebrowser-2.3.1; export _LOCKS_HEL...)

As far as I understand no test has been run at this stage. It's still
preparing files for the tests.

I don't have much python or tox knowledge. But maybe this can be fixed?
If not, adding NO_TEST=Yes with a comment that states the reason would
be good to indicate that this has been looked at already.

Besides that, LGTM.

Best regards,
Stefan