Friday, August 06, 2021

Re: new: devel/libmarisa: tire library wanted by some IME pkgs

On 2021/08/06 05:47, Yifei Zhan wrote:
> Hi,
>
> The attached port is a C++ library for MARISA, which is a static and
> space-efficient trie data structure. This library is used by IME related
> packages such as libskk and librime, which I would like to import in
> future.
>
> I tested it on the following platforms using the included
> marisa-benchmark command, and with all titles in English wikipedia as
> input. It works fine.
>
> Tested on:
> amd64
> aarch64 (rpi4)
> mips64el (loongson) (with reduced input)
>
> ... all running the latest snapshot.
>
> The tarball is also available on the web:
> https://github.com/ZhanYF/static/raw/main/libmarisa.tar
>
> comments? ok to import?


Thanks, it's in pretty decent shape already but here's a tweaked version:

- whitespace tidying
- add missed WANTLIB
- change category to just textproc, i think that's fine by itself,
devel is pretty full so i prefer to use a different category where
it makes sense


make test fails to build, do you have any ideas about that?


marisa-test.cc:21:23: error: expected unqualified-id
EXCEPT(trie.write(::fileno(stdout)), MARISA_STATE_ERROR);
^
/usr/include/stdio.h:410:19: note: expanded from macro 'fileno'
#define fileno(p) (!__isthreaded ? __sfileno(p) : (fileno)(p))
^
1 error generated.

No comments:

Post a Comment