Thursday, September 09, 2021

Re: [macppc / lld] devel/gmp text relocation

On Thu, 9 Sep 2021 16:15:53 +0200
Christian Weisgerber <naddy@mips.inka.de> wrote:

> George Koehler:
>
> > WRKSRC/mpn/asm-defs.m4:1054,
> >
> > ifelse(`PIC_ALWAYS',`yes',`define(`PIC')')
> >
> > Notice that `PIC_ALWAYS' is in quotes, so the macro PIC_ALWAYS is
> > not expanded. This faulty check compares the literal string
> > "PIC_ALWAYS" with the literal string "yes"; these strings never
> > match, so this faulty check never defines PIC. I don't fix this
> > faulty check, because it might affect other archs.
>
> It appears that check is only used on powerpc*. The only place I
> can find that defines PIC_ALWAYS is in GMP_ASM_POWERPC_PIC_ALWAYS,
> which is indeed only called on powerpc*.
>
> So the fix might be as simple as repairing that ifelse?

Well, this fixes devel/xtensa-lx106-elf/gdb :

https://bin.charlenew.xyz/xtensa-lx106-elf-gdb-8.2.1p0.log



> --
> Christian "naddy" Weisgerber
> naddy@mips.inka.de
>

No comments:

Post a Comment