Re: sysutils/gource missing a rundep on git

On 2021/09/21 08:30, Ian Darwin wrote:
> On Tue, Sep 21, 2021 at 01:21:18PM +0100, Stuart Henderson wrote:
> > On 2021/09/21 14:12, Stefan Sperling wrote:
> > > On Tue, Sep 21, 2021 at 02:04:09PM +0200, Solene Rapenne wrote:
> > > > gource package doesn't have a run depend on git which
> > > > make it fail on use.
> > > >
> > > > $ gource
> > > > sh: git: not found
> > > > sh: git: not found
> > > > gource: failed to generate log file
> > > > Try 'gource --help' for more information.
> > > >
> > > > following diff make gource working out of the box
> > >
> > > The gource README.md file lists the following VCS as supported:
> > > Git, Bazaar, Mercurial, SVN, CVS
> > >
> > > I would expect that you'd need the corresponding tools for each
> > > of these to make use of gource, depending on the repository format?
> >
> > yes, for cvs:
> >
> > pkg_add cvs2cl
> > cvs2cl --chrono --xml
> > gource ChangeLog
>
> Git, CVS and SVN are probably needed. Bazaar and Mercurial are not that
> commonly used; maybe list them in a package-readme as optional deps?
>

I would opt for a quick note in DESCR. The current text is misleading

"Currently Gource includes built-in log generation support for Git,
Mercurial and Bazaar and SVN."

which implies it doesn't need anything else for these..

Given that most users who have a checkout from VCS $X will already have
$X installed, and that the error message is clear, I don't think it
really needs to enforce dependencies.

(bzr is removed, nobody opted to port brz, so there's no Bazaar support
in ports at the moment).