Re: UPDATE: Aircrack-ng 1.6

On Fri, Aug 27, 2021 at 01:10:52AM -0400, Brad Smith wrote:
> On 8/20/2021 11:12 PM, Brad Smith wrote:
> > Here is an update to Aircrack-ng 1.6.
> >
> > Other than building the package that is all I have tested on amd64
> > and i386.
> >
> > Any users familiar with Aircrack-ng able to test this out?

Make use of GNU libtool. As Stuart pointed out the regress tests
pass in full with this. Without, 21 out of 38 fail.


Index: Makefile
===================================================================
RCS file: /home/cvs/ports/security/aircrack-ng/Makefile,v
retrieving revision 1.33
diff -u -p -u -p -r1.33 Makefile
--- Makefile 27 Dec 2020 18:13:18 -0000 1.33
+++ Makefile 2 Sep 2021 22:16:49 -0000
@@ -1,8 +1,8 @@
# $OpenBSD: Makefile,v 1.33 2020/12/27 18:13:18 sthen Exp $

COMMENT= 802.11 WEP and WPA-PSK keys cracking program
-DISTNAME= aircrack-ng-1.5.2
-REVISION= 6
+
+DISTNAME= aircrack-ng-1.6
CATEGORIES= security

HOMEPAGE= https://www.aircrack-ng.org/
@@ -10,8 +10,7 @@ HOMEPAGE= https://www.aircrack-ng.org/
# GPLv2
PERMIT_PACKAGE= Yes

-WANTLIB+= c pthread crypto z pcre
-WANTLIB+= ${COMPILER_LIBCXX} m sqlite3
+WANTLIB+= ${COMPILER_LIBCXX} c crypto m pcre pthread sqlite3 ssl z

MASTER_SITES= https://download.aircrack-ng.org/

@@ -22,11 +21,8 @@ LIB_DEPENDS= databases/sqlite3 \

RUN_DEPENDS+= net/arp-scan,-mac>=20190128

+USE_LIBTOOL= gnu
USE_GMAKE= Yes
-.if ${MACHINE_ARCH} == "i386"
-# ld: error: undefined symbol: __i686.get_pc_thunk.bx
-USE_LLD= No
-.endif
LIBTOOL_FLAGS= --tag=disable-static
AUTOCONF_VERSION= 2.69
AUTOMAKE_VERSION= 1.16
@@ -56,8 +52,7 @@ PKG_ARGS+= -Darm=0
MAKE_ENV+= ALTIVEC=false POWER8=false
.endif

-
pre-configure:
- ${SUBST_CMD} ${WRKSRC}/src/airodump-ng.h
+ ${SUBST_CMD} ${WRKSRC}/src/airodump-ng/airodump-ng.c

.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /home/cvs/ports/security/aircrack-ng/distinfo,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 distinfo
--- distinfo 23 Feb 2019 22:23:25 -0000 1.4
+++ distinfo 20 Aug 2021 00:21:44 -0000
@@ -1,2 +1,2 @@
-SHA256 (aircrack-ng-1.5.2.tar.gz) = nlkv52WARiIOCsCm0FxAJpA/MHeySIk+AFbMvk7ogkE=
-SIZE (aircrack-ng-1.5.2.tar.gz) = 7138360
+SHA256 (aircrack-ng-1.6.tar.gz) = Twv9SG78bqcin3+8VDQP+LIJSg1z6fYX4KOfh4mZokc=
+SIZE (aircrack-ng-1.6.tar.gz) = 7933308
Index: patches/patch-build_m4_aircrack_ng_simd_m4
===================================================================
RCS file: patches/patch-build_m4_aircrack_ng_simd_m4
diff -N patches/patch-build_m4_aircrack_ng_simd_m4
--- patches/patch-build_m4_aircrack_ng_simd_m4 13 Jun 2020 17:38:49 -0000 1.1
+++ /dev/null 1 Jan 1970 00:00:00 -0000
@@ -1,25 +0,0 @@
-$OpenBSD: patch-build_m4_aircrack_ng_simd_m4,v 1.1 2020/06/13 17:38:49 cwen Exp $
-
-Ensure that disabling AltiVec and POWER8 instructions with MAKE_ENV is honoured
-even if the build machine supports them, from:
-https://github.com/aircrack-ng/aircrack-ng/issues/1941
-
-Index: build/m4/aircrack_ng_simd.m4
---- build/m4/aircrack_ng_simd.m4.orig
-+++ build/m4/aircrack_ng_simd.m4
-@@ -132,7 +132,6 @@ then
- AX_CHECK_COMPILE_FLAG([-maltivec], [
- AX_APPEND_FLAG(-maltivec, [ppc_altivec_[]_AC_LANG_ABBREV[]flags])
- AC_SUBST(ppc_altivec_[]_AC_LANG_ABBREV[]flags)
-- ALTIVEC_FOUND=1
- ])
-
- AX_CHECK_COMPILE_FLAG([-mabi=altivec], [
-@@ -148,7 +147,6 @@ then
- AX_CHECK_COMPILE_FLAG([-mpower8-vector], [
- AX_APPEND_FLAG(-mpower8-vector, [ppc_altivec_[]_AC_LANG_ABBREV[]flags])
- AC_SUBST(ppc_altivec_[]_AC_LANG_ABBREV[]flags)
-- POWER8_FOUND=1
- ])
- fi
-
Index: patches/patch-include_aircrack-ng_crypto_sha1-sse2_h
===================================================================
RCS file: patches/patch-include_aircrack-ng_crypto_sha1-sse2_h
diff -N patches/patch-include_aircrack-ng_crypto_sha1-sse2_h
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-include_aircrack-ng_crypto_sha1-sse2_h 20 Aug 2021 00:21:44 -0000
@@ -0,0 +1,365 @@
+$OpenBSD$
+
+chore: remove unused assembly routines
+
+Index: include/aircrack-ng/crypto/sha1-sse2.h
+--- include/aircrack-ng/crypto/sha1-sse2.h.orig
++++ include/aircrack-ng/crypto/sha1-sse2.h
+@@ -36,357 +36,3 @@
+ #include <time.h>
+
+ #include <aircrack-ng/crypto/crypto.h>
+-
+-#if defined(__i386__) || ((defined(__x86_64__) && !defined(__CYGWIN__)) \
+- || (defined(__x86_64__) && defined(__CYGWIN__) \
+- && !defined(__clang__)))
+-
+-#ifdef OLD_SSE_CORE
+-void show_result(char * key, unsigned char * pmk)
+-{
+- int i;
+- printf("%-14s ", key);
+- for (i = 0; i < 32; i++) printf("%.2X", pmk[i]);
+- printf("\n");
+-}
+-
+-