Re: LLVM 13 ports build failures (2021-10-27)

On Wed, Oct 27, 2021 at 07:48:52PM -0600, Thomas Frohwein wrote:
> On Thu, Oct 28, 2021 at 12:16:58AM +0200, Christian Weisgerber wrote:
> [...]
> > Failure logs:
> > http://build-failures.rhaalovely.net/amd64-clang/2021-10-27/
> >
> > The final error may be misleading. For instance, devel/libdsm fails
> > with a linker error "undefined reference to pthread_create", but
> > the root cause is -Werror breaking a configure check.
>
> fvwm2 may be an exception here. I looked through the log and can't find
> any error before the linker error:
>
> ld: error: /usr/local/lib/libintl.so.7.0: undefined reference to pthread_mutexattr_init [--no-allow-shlib-undefined]
> ld: error: /usr/local/lib/libintl.so.7.0: undefined reference to pthread_mutexattr_settype [--no-allow-shlib-undefined]
> ld: error: /usr/local/lib/libintl.so.7.0: undefined reference to pthread_mutexattr_destroy [--no-allow-shlib-undefined]
>
> Leads me to conclude that we need to add -lpthread now to satisfy
> clang13. Diff for that below; CC maintainer. ok?

No objections from my (maintainer) side.

>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/x11/fvwm2/Makefile,v
> retrieving revision 1.71
> diff -u -p -r1.71 Makefile
> --- Makefile 19 Sep 2021 21:11:55 -0000 1.71
> +++ Makefile 28 Oct 2021 01:47:33 -0000
> @@ -3,7 +3,7 @@
> COMMENT= multiple virtual desktop window manager
>
> VERSION= 2.6.9
> -REVISION= 1
> +REVISION= 2
> DISTNAME= fvwm-${VERSION}
> PKGNAME= fvwm2-${VERSION}
>
> @@ -19,7 +19,7 @@ PERMIT_PACKAGE= Yes
>
> WANTLIB += ICE SM X11 Xcursor Xext Xft Xinerama Xpm Xrender
> WANTLIB += c cairo curses fontconfig freetype gdk_pixbuf-2.0
> -WANTLIB += gio-2.0 glib-2.0 gobject-2.0 iconv intl m png
> +WANTLIB += gio-2.0 glib-2.0 gobject-2.0 iconv intl m png pthread
> WANTLIB += readline rsvg-2 z
>
> MASTER_SITES= https://github.com/fvwmorg/fvwm/releases/download/${VERSION}/
> @@ -47,6 +47,6 @@ CONFIGURE_ARGS+= --enable-mandoc \
> --without-rplay-library \
> --without-stroke-library
> CONFIGURE_ENV+= CPPFLAGS="${CPPFLAGS} -I${LOCALBASE}/include" \
> - LDFLAGS="${LDFLAGS} -L${LOCALBASE}/lib"
> + LDFLAGS="${LDFLAGS} -lpthread -L${LOCALBASE}/lib"
>
> .include <bsd.port.mk>
>