On Fri, Oct 29, 2021, at 2:18 PM, Thomas Frohwein wrote:
> On Fri, Oct 29, 2021 at 05:40:13PM +0100, Stuart Henderson wrote:
> > Thanks - this is ok with me
>
> committed, thanks
Thank you!
> > > > On 2021/10/29 13:19, Omar Polo wrote:
> > > >> I'm attaching an improved version with:
> > > >>
> > > >> - changed the version from 1.0 to 0.0.20180328. This way, if upstream
> > > >> ever decides to tag a version less than 1.0 we won't have troubles.
> > > >>
> > > >> - HOMEPAGE is not needed, it already defaults to that value.
> > > >>
> > > >> - same for EXTRACT_SUFX and MASTER_SITES
> > > >>
> > > >> - missing license comment before PERMIT_PACKAGE
> > > >>
> > > >> - we can avoid patching the makefile by tweaking FAKE_FLAGS to override
> > > >> the makefile' BINDIR.
> > > >>
> > > >> - indentation
Thanks for the improvements, I'm very new to setting up ports so this
is educational for me even as a very simple example.
Allan
No comments:
Post a Comment