Stuart Henderson <stu@spacehopper.org> writes:
> On 2021/10/29 13:19, Omar Polo wrote:
>> "Allan Streib" <astreib@fastmail.fm> writes:
>>
>> > This is a little utility that I have found useful when processing CSV
>> > files that may contain delimeters or newlines within data fields.
>> >
>> > https://github.com/dbro/csvquote
>> >
>> > The project provides no release/tags or man page.
>>
>> that's sad :/
>>
>> > I offer the attached port for comments/testing.
>> >
>> > I have tested only on amd64.
>> >
>> > Allan
>>
>> I'm attaching an improved version with:
>>
>> - changed the version from 1.0 to 0.0.20180328. This way, if upstream
>> ever decides to tag a version less than 1.0 we won't have troubles.
>>
>> - HOMEPAGE is not needed, it already defaults to that value.
>>
>> - same for EXTRACT_SUFX and MASTER_SITES
>>
>> - missing license comment before PERMIT_PACKAGE
>>
>> - we can avoid patching the makefile by tweaking FAKE_FLAGS to override
>> the makefile' BINDIR.
>>
>> - indentation
>
> those are all ok with me
>
>> - I don't think installing the project README is useful. The "know
>> limitations" part is surely useful, but the rest of the readme not
>> that much.
>
> in the absence of a manual, i do think the readme is useful because
> it describes what the tool does. i'm ok to import this with the readme
> added back in.
sounds fair. Attaching an updated tarball with the readme installed.
(also, I forgot to mention that WANTLIB was missing)
>> I don't mess with csv files often, but I see why something like this
>> could be useful.
>>
>> btw, it could be possible (and quite easy really) to run cvsquote under
>> pledge("stdio rpath", NULL). The code is simple to follow, is a simple
>> filter after all :)
>>
>> Cheers,
>>
>> Omar Polo
>>
No comments:
Post a Comment