On 2021/10/30 14:09, Landry Breuil wrote:
> I've tried various things in our Makefile.inc, but using LDFLAGS_NODIST
> / CFLAGS_NODIST generally ends up with a broken libintl/textdomain
> detection, so i went with a patch that is similar to the freebsd one so
> that LDFLAGS/paths dont leak to _sysconfigdata__openbsd7_py.
>
> $grep LDSH /usr/local/lib/python3.8/_sysconfigdata__openbsd7_.pyi
> 'BLDSHARED': 'cc -pthread -shared -fPIC',
> 'LDSHARED': 'cc -pthread -shared -fPIC',
>
> CFLAGS_NODIST in MAKE_FLAGS is needed, otherwise python build itself
> fails because it cant find libintl.h.
>
> im not sure this is the right patch at all. This might go in a bulk
> soon to check for fallout...if testing the diff, make sure to diff
> _sysconfigdata__openbsd7_.py before and after.
I think this makes sense if there are no problems in bulk. (Enough of
python is run during a build to exercise things that I don't think
it would need separate runtime tests).
I'm unsure if changes to the build makefiles count as changes to python
for the license requirement (*/files/CHANGES.OpenBSD), but it might need
a line in there before commit
No comments:
Post a Comment