Saturday, October 30, 2021

Re: unbreak (and update) productivity/vdirsyncer.

On Sat, Oct 30, 2021 at 03:53:20PM +0200, Paco Esteban wrote:
> On Sat, 30 Oct 2021, Remi Locherer wrote:
>
> > Hi Paco,
> >
> > On Sat, Oct 30, 2021 at 01:52:04PM +0200, Paco Esteban wrote:
> > > Hi ports@,
> > >
> > > I just found out that productivity/vdirsyncer was not working because
> > > one of its dependencies (devel/py-click-threading) was broken.
> > >
> > > Here's a patch that updates deve/py-click-threading to its latest
> > > version (0.5.0), which fixes the bug and another one that updates
> > > productivity/vdirsyncer to 0.18.0. It seems that 0.19.0 exists for the
> > > latter, but is not on pypi, only on their github repo.
> >
> > I see 0.19.0 in Changelog.rst but it is not tagged yet on GitHub.
>
> I guess that's it. I'll take a look when they put it on pypi.
>
> >
> > > Both build and work for me on amd64. vdirsyncer also has tests, which
> > > all but one pass. That one is trying to make a network connection which
> > > we do not allow when using PORTS_PRIVSEP.
> > >
> > > Maintainer of vdirsyncer in CC
> > >
> > > OK to commit ?
> >
> > I have the same diff and vdirsyncer runs fine with it. OK to commit.
> >
> > Test do not run because a newer py-coverage is required. And that needs
> > a newer py-test. But the required py-test version is python3 only ....
>
> what do you mean ?
> Tests run ok for me just adding devel/py-test-cov to TEST_DEPENDS.

You're right, the tests run fine. I don't remember what made me
belief a new version of py-coverage is required ....

Remi

No comments:

Post a Comment