Tuesday, November 02, 2021

Re: lang/dmd: Prepare for i386 package

Hi Stuart --

On 11/02/2021 05:23 AM, Stuart Henderson wrote:
> On 2021/11/02 03:58, Brian Callahan wrote:
>> There's no bump, since there is no change in the resulting package on
>> amd64.
>> For amd64, we are just variablizing every instance of 64 to ${MODEL}
>> in the
>> port Makefile. The i386-specific patch does not get applied on amd64.
>
> arch-specific patches are annoying to deal with for uodates, is there a
> way
> to do it with a single patch? (i have no idea if D has anything like
> cpp
> that could be used)
>

There is no preprocessor in D. That's an explicit design choice by them.

There is a runtime way to check which arch you are using. Of course,
that would change the amd64 binary too. So I'll leave the patch out for
now and reintroduce it later with the i386 bootstrap infrastructure and
some additional i386 patches.

But my goal is to get rid of this patch asap anyway...

> if it's the only way then ok, just trying to save later trouble
>
> ${MODEL} is good, that is definitely ok
>
>> + if (i == -1) // error, errno is set
>> + return corrupt(__LINE__);
>> +- om.file_time = statbuf.st_ctime;
>> ++ om.file_time = cast(int)statbuf.st_ctime;
>
> 32-bit timestamps :-(

...because yeah, the crappiness of this was not lost on me. I just have
to find the exact place to fix this. It's on my immediate todo list.

Thanks.

~Brian

No comments:

Post a Comment