libdsm and clang 13 (was: Re: LLVM 13 ports build failures (2021-11-27))

On Sun, Nov 28 2021, Christian Weisgerber <naddy@mips.inka.de> wrote:
> I ran another amd64 bulk build with base clang updated to LLVM 13.
> I also put in a tentative fix for security/nss.
>
> Failure logs:
> http://build-failures.rhaalovely.net/amd64-clang/2021-11-27/
>
[...]

> devel/libdsm -Werror breaks pthread autoconf test

http://build-failures.rhaalovely.net/amd64-clang/2021-11-27/devel/libdsm.log

Here's a way to fix this issue while keeping -Werror as used by the
configure script. Upstream has since moved to meson so the patch won't
apply for obvious reasons in the next update.

ok?


Index: patches/patch-configure
===================================================================
RCS file: patches/patch-configure
diff -N patches/patch-configure
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-configure 1 Dec 2021 23:29:00 -0000
@@ -0,0 +1,16 @@
+$OpenBSD$
+
+Adapt configure test to work with -Werror and -Wunused-but-set-variable
+
+Index: configure
+--- configure.orig
++++ configure
+@@ -13793,7 +13793,7 @@ $as_echo_n "checking for the pthreads library -l$flag.
+ cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+ /* end confdefs.h. */
+ #include <pthread.h>
+- static void routine(void *a) { a = 0; }
++ static void routine(void *a) { (void)a; }
+ static void *start_routine(void *a) { return a; }
+ int
+ main ()

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE