On Sun Dec 12, 2021 at 03:41:48PM +0100, Rafael Sadowski wrote:
> On Sun Dec 12, 2021 at 11:52:40AM +0000, Stuart Henderson wrote:
> > Related to the "policy for dlopen'd libraries etc" mail I just posted but
> > worth a separate thread I think ..
> >
> > When you see "LIB_DEPENDS <xx> not needed for <yy>" when "make package"
> > runs, it means that the LIB_DEPENDS entry is *ignored* as a run dependency
> > and is equivalent to BUILD_DEPENDS.
> >
> > : LIB_DEPENDS <spec> not needed for <FULLPKGPATH> There doesn't seem to be
> > : any WANTLIB to match the given LIB_DEPENDS. Thus, the LIB_DEPENDS won't
> > : turn into a @depends line in the created package.
> >
> > This is nearly always an error - bsd.port.mk(5) lists some "might be
> > intentional" but those cases are rare and could be handled with conditionals
> > instead (perhaps it would be better if we do turn it into an actual error).
> >
> > I think all current cases in ports *are* an error:
> >
> > audio/moc LIB_DEPENDS devel/gettext,-runtime not needed for audio/moc ?
> > audio/cantata LIB_DEPENDS audio/libebur128 not needed for audio/cantata ?
> > x11/kde-applications/kcron LIB_DEPENDS devel/kf5/kiconthemes not needed for x11/kde-applications/kcron ?
>
> Exactly, I fixed that a few days ago.
>
> > x11/pidgin-libnotify LIB_DEPENDS net/pidgin,-libpurple not needed for x11/pidgin-libnotify ?
> > graphics/opencsg LIB_DEPENDS x11/qt5/qtbase,-main not needed for graphics/opencsg ?
>
> Maybe MODQT_DEPS = No helps here.
>
> > graphics/piglit LIB_DEPENDS graphics/vulkan-loader not needed for graphics/piglit ?
> > net/pidgin LIB_DEPENDS lang/python/3.9 not needed for net/pidgin,-finch ?
> > editors/calligra LIB_DEPENDS devel/kf5/kcalendarcore not needed for editors/calligra ?
> > editors/calligra LIB_DEPENDS devel/kf5/kcontacts not needed for editors/calligra ?
> > editors/calligra LIB_DEPENDS textproc/libwpd not needed for editors/calligra ?
>
> I'll fix calligra.
>
Index: Makefile
===================================================================
RCS file: /cvs/ports/editors/calligra/Makefile,v
retrieving revision 1.47
diff -u -p -u -p -r1.47 Makefile
--- Makefile 31 Aug 2021 07:31:43 -0000 1.47
+++ Makefile 12 Dec 2021 17:48:50 -0000
@@ -5,7 +5,7 @@ HOMEPAGE = https://www.calligra.org
VERSION = 3.2.1
DISTNAME = calligra-${VERSION}
CATEGORIES = editors
-REVISION = 3
+REVISION = 4
SHARED_LIBS = RtfReader 51.0 # 0.0
SHARED_LIBS += basicflakes 50.0 # 0.0
@@ -50,8 +50,7 @@ MAINTAINER = Rafael Sadowski <rsadowski@
PERMIT_PACKAGE = Yes
DPB_PROPERTIES = parallel
-WANTLIB += ${COMPILER_LIBCXX} ICE Iex-3_1
-WANTLIB += IlmThread-3_1 Imath-3_1 KChart KF5Activities KF5Archive
+WANTLIB += ${COMPILER_LIBCXX} ICE KChart KF5Activities KF5Archive
WANTLIB += KF5Auth KF5AuthCore KF5Bookmarks KF5Codecs KF5Completion
WANTLIB += KF5ConfigCore KF5ConfigGui KF5ConfigWidgets KF5CoreAddons
WANTLIB += KF5Crash KF5DBusAddons KF5GuiAddons KF5I18n KF5IconThemes
@@ -74,6 +73,8 @@ COMPILER = base-clang ports-gcc
BUILD_DEPENDS = devel/boost \
devel/gettext,-tools \
+ devel/kf5/kcalendarcore \
+ devel/kf5/kcontacts \
devel/kf5/kdoctools \
devel/kf5/kinit \
devel/kf5/kross \
@@ -83,6 +84,8 @@ BUILD_DEPENDS = devel/boost \
RUN_DEPENDS = devel/desktop-file-utils \
devel/gettext,-runtime \
+ devel/kf5/kcalendarcore \
+ devel/kf5/kcontacts \
devel/kf5/kinit \
devel/kf5/ktexteditor \
misc/shared-mime-info \
@@ -93,13 +96,11 @@ LIB_DEPENDS = converters/libiconv \
devel/gsl \
devel/kf5/kactivities \
devel/kf5/karchive \
- devel/kf5/kcalendarcore \
devel/kf5/kcmutils \
devel/kf5/kcodecs\
devel/kf5/kcompletion \
devel/kf5/kconfig \
devel/kf5/kconfigwidgets \
- devel/kf5/kcontacts \
devel/kf5/kcoreaddons \
devel/kf5/kdbusaddons \
devel/kf5/kdelibs4support \
@@ -120,11 +121,9 @@ LIB_DEPENDS = converters/libiconv \
devel/kf5/sonnet \
graphics/kdiagram \
graphics/lcms2 \
- graphics/openexr \
multimedia/phonon \
print/poppler,-qt5 \
security/qca-qt5 \
- textproc/libwpd \
x11/kde-applications/okular \
x11/qt5/qtdeclarative \
x11/qt5/qtsvg \
No comments:
Post a Comment