Re: "LIB_DEPENDS not needed for"

Rafael Sadowski wrote:
> On Sun Dec 12, 2021 at 11:52:40AM +0000, Stuart Henderson wrote:
> > Related to the "policy for dlopen'd libraries etc" mail I just posted but
> > worth a separate thread I think ..
> >
> > When you see "LIB_DEPENDS <xx> not needed for <yy>" when "make package"
> > runs, it means that the LIB_DEPENDS entry is *ignored* as a run dependency
> > and is equivalent to BUILD_DEPENDS.
> >
> > : LIB_DEPENDS <spec> not needed for <FULLPKGPATH>  There doesn't seem to be
> > : any WANTLIB to match the given LIB_DEPENDS. Thus, the LIB_DEPENDS won't
> > : turn into a @depends line in the created package.
> >
> > This is nearly always an error - bsd.port.mk(5) lists some "might be
> > intentional" but those cases are rare and could be handled with conditionals
> > instead (perhaps it would be better if we do turn it into an actual error).
> >
> > I think all current cases in ports *are* an error:
> >
> > audio/moc LIB_DEPENDS devel/gettext,-runtime not needed for audio/moc ?
>
> I see no gettext usage in the moc source tree. While I'm here, fix
> WANTLIB by regen.
>
> OK?

Tested with not packages preinstalled.

OK sdk@

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/audio/moc/Makefile,v
> retrieving revision 1.24
> diff -u -p -r1.24 Makefile
> --- Makefile 26 Jan 2020 11:14:29 -0000 1.24
> +++ Makefile 12 Dec 2021 15:52:07 -0000
> @@ -7,18 +7,18 @@ HOMEPAGE = http://moc.daper.net/
> MASTER_SITES = http://ftp.daper.net/pub/soft/moc/stable/ \
> https://distfiles.sigtrap.nl/
> EXTRACT_SUFX = .tar.bz2
> -REVISION = 7
> +REVISION = 8
>
> # GPLv3+
> PERMIT_PACKAGE = Yes
>
> # uses pledge()
> -WANTLIB += ${COMPILER_LIBCXX}
> -WANTLIB += FLAC avcodec avformat avutil bz2 c crypto curl curses
> -WANTLIB += db faad gsm iconv id3tag ltdl m mad magic modplug mp3lame
> -WANTLIB += mpcdec nghttp2 ogg opus samplerate sndfile sndio speex
> -WANTLIB += ssl swresample tag tag_c vorbis vorbisenc vorbisfile
> -WANTLIB += vpx wavpack x264 x265 xvidcore z
> +WANTLIB += ${COMPILER_LIBCXX} FLAC aom avcodec avformat avutil
> +WANTLIB += bz2 c crypto curl curses dav1d db faad gsm iconv id3tag
> +WANTLIB += ltdl lzma m mad magic modplug mp3lame mpcdec nghttp2
> +WANTLIB += ogg opus samplerate sndfile sndio speex ssl swresample
> +WANTLIB += tag tag_c theoradec theoraenc vorbis vorbisenc vorbisfile
> +WANTLIB += vpx wavpack x264 x265 xml2 xvidcore z
>
> COMPILER = base-clang ports-gcc base-gcc
>
> @@ -35,7 +35,6 @@ LIB_DEPENDS = audio/faad \
> audio/speex \
> audio/taglib \
> databases/db/v4 \
> - devel/gettext,-runtime \
> devel/libmagic \
> devel/libtool,-ltdl \
> graphics/ffmpeg \
>

--
STEFAN HAGEN // GPG 0x52BE43BA
CONTACT INFO :: finger(1) @codevoid.de