Re: [new] net/py-geoip2

On 2021-12-08 15:49, Stuart Henderson wrote:
> On 2021/12/08 10:31, Johan Huldtgren wrote:
> > hello,
> >
> > this a new port for py-geoip2 which provides an API for
> > the GeoIP2 and GeoLite2 web services and databases. This
> > is a dependency for another port I'm working on. This
> > depends on the new net/py-maxminddb port. Built,
> > packaged, and tested on amd64.
> >
> > thanks.
> >
> > .jh
>
> py-pip + py-wheel are used to download+install missing modules for tests,
> but that isn't allowed anyway.
>
> I would either go for this, or add a port for mocket and set TEST_DEPENDS to
> that (no need to list RUN_DEPENDS separately, that's implicit).

Thanks, that makes sense. Updated tgz attached with changes as
below.

.jh


> diff --git net/py-geoip2/Makefile net/py-geoip2/Makefile
> index 6712ca5..5c54b8b 100755
> --- net/py-geoip2/Makefile
> +++ net/py-geoip2/Makefile
> @@ -15,7 +15,8 @@ PERMIT_PACKAGE = Yes
>
> MODULES = lang/python
> MODPY_PI = Yes
> -MODPY_SETUPTOOLS = Yes
> +MODPY_SETUPTOOLS = Yes
> +MODPY_PYTEST = Yes
>
> FLAVORS = python3
> FLAVOR = python3
> @@ -26,8 +27,7 @@ RUN_DEPENDS = net/libmaxminddb,-db \
> www/py-requests${MODPY_FLAVOR} \
> www/py-urllib3${MODPY_FLAVOR}
>
> -TEST_DEPENDS = ${RUN_DEPENDS} \
> - devel/py-pip${MODPY_FLAVOR} \
> - devel/py-wheel${MODPY_FLAVOR}
> +# requires mocket (not yet ported)
> +NO_TEST = Yes
>
> .include <bsd.port.mk>
>