Tuesday, December 21, 2021

Re: sparc64 bulk build report

> http://build-failures.rhaalovely.net/sparc64/2021-12-18/math/cglm.log

> /usr/obj/ports/cglm-0.8.4/cglm-0.8.4/test/src/test_cam_lh_zo.c: In function 'test_perspective_lh_zo':
> /usr/obj/ports/cglm-0.8.4/cglm-0.8.4/test/src/test_cam_lh_zo.c:28: warning: missing braces around initializer
> /usr/obj/ports/cglm-0.8.4/cglm-0.8.4/test/src/test_cam_lh_zo.c:28: warning: (near initialization for 'cmp[0]')

it fails also on aarch64 for a similar reason (unused but set variable.)
This missing braces around initializer could be patched easily
(althought I can't reproduce here), but the aarch64 failure doesn't seem
obvious so I'd prefer to disable -Werror and let the package build.

I'll commit the following in a few days if nobody objects


Index: Makefile
===================================================================
RCS file: /home/cvs/ports/math/cglm/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile 10 Dec 2021 13:27:02 -0000 1.1.1.1
+++ Makefile 21 Dec 2021 22:51:39 -0000
@@ -2,6 +2,7 @@

COMMENT = highly optimized graphics math library

+REVISION = 0
GH_ACCOUNT = recp
GH_PROJECT = cglm
GH_TAGNAME = v0.8.4
Index: patches/patch-CMakeLists_txt
===================================================================
RCS file: /home/cvs/ports/math/cglm/patches/patch-CMakeLists_txt,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 patch-CMakeLists_txt
--- patches/patch-CMakeLists_txt 10 Dec 2021 13:27:02 -0000 1.1.1.1
+++ patches/patch-CMakeLists_txt 21 Dec 2021 22:51:26 -0000
@@ -1,6 +1,6 @@
$OpenBSD: patch-CMakeLists_txt,v 1.1.1.1 2021/12/10 13:27:02 op Exp $

- - don't hardcode optimization flags
+ - don't hardcode optimization flags and drop -Werror
- set PACKAGE_VERSION for cglm.pc.in

Index: CMakeLists.txt
@@ -11,7 +11,7 @@ Index: CMakeLists.txt
endforeach(flag_var)
else()
- add_compile_options(-Wall -Werror -O3)
-+ add_compile_options(-Wall -Werror)
++ add_compile_options(-Wall)
endif()

if(NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)

No comments:

Post a Comment