Re: [UPDATE] devel/libinotify

At the time of import we did not want it to be picked up automatically by random ports. Because we weren't sure about the quality of it versus other local implementation of watchers in the applications themselves.
There were issues at the time, random locks, fd exhaustion etc.

Things may be better now.


—
Antoine

> On 1 Dec 2021, at 21:20, Rafael Sadowski <rafael@sizeofvoid.org> wrote:
>
> On Thu Nov 11, 2021 at 01:45:16PM +0300, Kirill Bychkov wrote:
>> Hi all,
>>
>> This is an update for libinotify. All consumers are building fine.
>> Run-time tests with owncloudclient are also fine.
>> OK to commit?
>
> Sorry for the off-topic question, but why we install libinotify in
> ${PREFIX}/lib/inotify and not ${PREFIX}/lib?
>
> Rafael
>
>>
>> Index: Makefile
>> ===================================================================
>> RCS file: /cvs/ports/devel/libinotify/Makefile,v
>> retrieving revision 1.15
>> diff -u -p -u -p -r1.15 Makefile
>> --- Makefile 19 Dec 2020 23:25:48 -0000 1.15
>> +++ Makefile 11 Nov 2021 08:43:32 -0000
>> @@ -4,10 +4,10 @@ COMMENT = kevent based inotify
>>
>> GH_ACCOUNT = libinotify-kqueue
>> GH_PROJECT = libinotify-kqueue
>> -GH_TAGNAME = 20180201
>> +GH_TAGNAME = 20211018
>> PKGNAME = libinotify-${GH_TAGNAME}
>>
>> -SHARED_LIBS = inotify 2.1
>> +SHARED_LIBS = inotify 3.0
>>
>> CATEGORIES = devel
>>
>> Index: distinfo
>> ===================================================================
>> RCS file: /cvs/ports/devel/libinotify/distinfo,v
>> retrieving revision 1.8
>> diff -u -p -u -p -r1.8 distinfo
>> --- distinfo 19 Dec 2020 23:25:48 -0000 1.8
>> +++ distinfo 11 Nov 2021 08:43:32 -0000
>> @@ -1,2 +1,2 @@
>> -SHA256 (libinotify-kqueue-20180201.tar.gz) =
>> Ffpt6LM7tzcXdVzpVm91cgmoVcogyT4gnG37sWl1mbI=
>> -SIZE (libinotify-kqueue-20180201.tar.gz) = 71808
>> +SHA256 (libinotify-kqueue-20211018.tar.gz) =
>> 4KMthn87bRBSS0XRbaVWEfv4vLuE69QOxJ49S2S3o6Y=
>> +SIZE (libinotify-kqueue-20211018.tar.gz) = 74778
>> Index: patches/patch-Makefile_am
>> ===================================================================
>> RCS file: /cvs/ports/devel/libinotify/patches/patch-Makefile_am,v
>> retrieving revision 1.6
>> diff -u -p -u -p -r1.6 patch-Makefile_am
>> --- patches/patch-Makefile_am 30 Aug 2017 05:37:36 -0000 1.6
>> +++ patches/patch-Makefile_am 11 Nov 2021 08:43:32 -0000
>> @@ -5,10 +5,10 @@ Unbreak separate build
>> Index: Makefile.am
>> --- Makefile.am.orig
>> +++ Makefile.am
>> -@@ -58,7 +58,7 @@ libinotify_la_SOURCES += compat/tree.h
>> - endif
>> +@@ -60,7 +60,7 @@ endif
>> + libinotify_la_SOURCES += compat/tree.h
>>
>> - libinotify_la_CFLAGS = -I. -DNDEBUG @PTHREAD_CFLAGS@ -Wall -Werror
>> + libinotify_la_CFLAGS = -I. @DEBUG_CFLAGS@ @PTHREAD_CFLAGS@ -Wall -Werror
>> -libinotify_la_LDFLAGS = @PTHREAD_LIBS@ -export-symbols libinotify.sym
>> +libinotify_la_LDFLAGS = @PTHREAD_LIBS@ -export-symbols
>> $(top_srcdir)/libinotify.sym
>> endif
>> Index: patches/patch-libinotify_pc_in
>> ===================================================================
>> RCS file: /cvs/ports/devel/libinotify/patches/patch-libinotify_pc_in,v
>> retrieving revision 1.1
>> diff -u -p -u -p -r1.1 patch-libinotify_pc_in
>> --- patches/patch-libinotify_pc_in 19 Sep 2019 13:33:57 -0000 1.1
>> +++ patches/patch-libinotify_pc_in 11 Nov 2021 08:43:32 -0000
>> @@ -5,9 +5,9 @@ Index: libinotify.pc.in
>> +++ libinotify.pc.in
>> @@ -1,7 +1,7 @@
>> prefix=@prefix@
>> - exec_prefix=${prefix}
>> --libdir=${exec_prefix}/lib
>> --includedir=${prefix}/include
>> + exec_prefix=@exec_prefix@
>> +-libdir=@libdir@
>> +-includedir=@includedir@
>> +libdir=${exec_prefix}/lib/inotify
>> +includedir=${prefix}/include/inotify
>>
>> Index: pkg/PLIST
>> ===================================================================
>> RCS file: /cvs/ports/devel/libinotify/pkg/PLIST,v
>> retrieving revision 1.4
>> diff -u -p -u -p -r1.4 PLIST
>> --- pkg/PLIST 17 Nov 2020 10:23:18 -0000 1.4
>> +++ pkg/PLIST 11 Nov 2021 08:43:32 -0000
>> @@ -12,6 +12,6 @@ lib/pkgconfig/libinotify.pc
>> @man man/man3/inotify_init.3
>> @man man/man3/inotify_init1.3
>> @man man/man3/inotify_rm_watch.3
>> -@man man/man3/inotify_set_param.3
>> @man man/man3/libinotify.3
>> +@man man/man3/libinotify_set_param.3
>> share/doc/pkg-readmes/${PKGSTEM}
>
>