Re: UPDATE: libtorrent-rasterbar 1.2.15

Brad Smith writes:

> Here is an update to libtorrent-rasterbar 1.2.15.

This is OK namn@, with a tweak to bump library major. I am looking for
another OK.

brad's diff tweaked with major bump is provided inline for convenience.

I propose a major bump because of removed symbols.
check_sym output:
https://namtsui.com/public/check_sym_libtorrent_1_2_15.txt
various headers related to major bump:
set_proxy_settings:
https://github.com/arvidn/libtorrent/commit/c83139e834457e440a91994667a4b5a50f668d6d
compare_peer / compare_peer_erase:
https://github.com/arvidn/libtorrent/commit/c430ca0b87f757a3181a97f7c43a76a9f28f6d4b
do_pause:
https://github.com/arvidn/libtorrent/commit/eea0820aa33e43d6875f79211f0f0651908a4265

Patch is removed because:
https://github.com/arvidn/libtorrent/commit/9cc638cdc6592c8570f4fc6333c51f2a7324279e

>
> This builds with C++17 as a workaround for newer Boost as mentioned
> in the ticket. This allows libtorrent-rasterber to function without
> crashing. I want to move forward with Boost 1.77.
>
> Tested with qbittorrent.

Tested with deluge and qbittorrent. make test similar to before passing
47 and skipping 2. There is no test_pex, which was skipped before.

>
>
> 1.2.15 released
>
> * cache DNS lookups for SOCKS5 proxy
> * fix stalled pieces on disk-full errors
> * fix build configuration issue on NetBSD, OpenBSD and DragonFly
> * make UTF-8 sanitization a bit stricter. This will re-write invalid UTF-8
> code points encoding surrogate pairs
> * fix restoring last_seen_complete from resume data
> * fix issue on MacOS where the DHT was not restarted on a network-up notification
> * make remove_torrent flags be treated as flags (instead of an enum)
>
> 1.2.14 released
>
> * improve handling of seed flag in PEX messages
> * fix issue of accruing unlimited DHT node candidates when DHT is disabled
> * fix bug in parsing chunked encoding
> * fix incorrect reporting of active_duration when entering graceful-pause
> * fix python binding for functions taking string_view
> * fix python binding for torrent_info constructor overloads
> * issue python deprecation warnings for some deprecated functions in the python bindings
> * fix python binding for torrent_info::add_url_seed, add_tracker and add_http_seed

Index: Makefile
===================================================================
RCS file: /cvs/ports/net/libtorrent-rasterbar/Makefile,v
retrieving revision 1.18
diff -u -p -u -p -r1.18 Makefile
--- Makefile 2 Nov 2021 00:01:39 -0000 1.18
+++ Makefile 30 Dec 2021 10:41:46 -0000
@@ -2,11 +2,10 @@

COMMENT = C++ library implementing a BitTorrent client

-MODPY_EGG_VERSION = 1.2.13
+MODPY_EGG_VERSION = 1.2.15
DISTNAME = libtorrent-rasterbar-${MODPY_EGG_VERSION}
-REVISION = 1

-SHARED_LIBS += torrent-rasterbar 4.0 # 10.0.0
+SHARED_LIBS += torrent-rasterbar 5.0 # 10.0.0

CATEGORIES = net devel

@@ -37,6 +36,10 @@ CONFIGURE_ARGS = --enable-python-binding
--with-boost-system=boost_system-mt \
--with-boost-python=boost_python${MODPY_VERSION:C/\.//g}-mt \
--with-libiconv
+
+# https://github.com/arvidn/libtorrent/issues/6468
+CONFIGURE_ARGS += --with-cxx-standard=17
+
CONFIGURE_ENV += CPPFLAGS="-Wno-deprecated-declarations \
-Wno-macro-redefined \
-pthread" \
Index: distinfo
===================================================================
RCS file: /cvs/ports/net/libtorrent-rasterbar/distinfo,v
retrieving revision 1.9
diff -u -p -u -p -r1.9 distinfo
--- distinfo 22 May 2021 21:47:28 -0000 1.9
+++ distinfo 30 Dec 2021 10:41:46 -0000
@@ -1,2 +1,2 @@
-SHA256 (libtorrent-rasterbar-1.2.13.tar.gz) = l20ncf/NVk8IpjNR6cIuhCqqjNKfb3/iXRacA4qEToU=
-SIZE (libtorrent-rasterbar-1.2.13.tar.gz) = 4160116
+SHA256 (libtorrent-rasterbar-1.2.15.tar.gz) = yK2GOGhMCpA+urwwSQB54xsaamONoq3sWovvag5iIUs=
+SIZE (libtorrent-rasterbar-1.2.15.tar.gz) = 4163049
Index: patches/patch-include_libtorrent_buffer_hpp
===================================================================
RCS file: patches/patch-include_libtorrent_buffer_hpp
diff -N patches/patch-include_libtorrent_buffer_hpp
--- patches/patch-include_libtorrent_buffer_hpp 6 Feb 2020 20:00:16 -0000 1.1
+++ /dev/null 1 Jan 1970 00:00:00 -0000
@@ -1,25 +0,0 @@
-$OpenBSD: patch-include_libtorrent_buffer_hpp,v 1.1 2020/02/06 20:00:16 rsadowski Exp $
-
-malloc_usable_size and malloc_size are unavailable
-
-Index: include/libtorrent/buffer.hpp
---- include/libtorrent/buffer.hpp.orig
-+++ include/libtorrent/buffer.hpp
-@@ -50,7 +50,7 @@ POSSIBILITY OF SUCH DAMAGE.
- #elif defined __FreeBSD__
- #include <malloc_np.h>
- #elif defined TORRENT_BSD
--#include <malloc/malloc.h>
-+#include <sys/malloc.h>
-