Re: UPDATE: SDL 2.0.18

On Sat, Dec 11, 2021 at 12:47:03AM -0500, Brad Smith wrote:
> Here is an update to SDL 2.0.18.

I have the same. The bulk of the work is dependency testing - have you
done any?

I am still in the process of going through consumers, but many of them
now hit the following assertions:

SDL_assert(current_audio.impl.OnlyHasDefaultOutputDevice);
SDL_assert(current_audio.impl.OnlyHasDefaultCaptureDevice || !current_audio.impl.HasCaptureSupport);

Have you seen any of this? Any idea why this is happening now and not
with 2.0.16?

Happens here with lagrange, teeworlds, scummvm and a few others, but
not all. It's more annoying - pressing 'A' twice gets past it.

[1] https://github.com/libsdl-org/SDL/blob/main/src/audio/SDL_audio.c#L229

>
>
> ---------------------------------------------------------------------------
> 2.0.18:
> ---------------------------------------------------------------------------
>
> General:
> * The SDL wiki documentation and development headers are automatically kept in sync
> * Each function has information about in which version of SDL it was introduced
> * Added the hint SDL_HINT_APP_NAME to let SDL know the name of your application for various places it might show up in system information
> * Added SDL_RenderGeometry() and SDL_RenderGeometryRaw() to allow rendering of arbitrary shapes using the SDL 2D render API
> * Added SDL_SetTextureUserData() and SDL_GetTextureUserData() to associate application data with an SDL texture
> * Added SDL_RenderWindowToLogical() and SDL_RenderLogicalToWindow() to convert between window coordinates and logical render coordinates
> * Added SDL_RenderSetVSync() to change whether a renderer present is synchronized with vblank at runtime
> * Added SDL_PremultiplyAlpha() to premultiply alpha on a block of SDL_PIXELFORMAT_ARGB8888 pixels
> * Added a window event SDL_WINDOWEVENT_DISPLAY_CHANGED which is sent when a window changes what display it's centered on
> * Added SDL_GetWindowICCProfile() to query a window's ICC profile, and a window event SDL_WINDOWEVENT_ICCPROF_CHANGED that is sent when it changes
> * Added the hint SDL_HINT_VIDEO_EGL_ALLOW_TRANSPARENCY to allow EGL windows to be transparent instead of opaque
> * SDL_WaitEvent() has been redesigned to use less CPU in most cases
> * Added SDL_SetWindowMouseRect() and SDL_GetWindowMouseRect() to confine the mouse cursor to an area of a window
> * You can now read precise mouse wheel motion using 'preciseX' and 'preciseY' event fields
> * Added SDL_GameControllerHasRumble() and SDL_GameControllerHasRumbleTriggers() to query whether a game controller supports rumble
> * Added SDL_JoystickHasRumble() and SDL_JoystickHasRumbleTriggers() to query whether a joystick supports rumble
> * SDL's hidapi implementation is now available as a public API in SDL_hidapi.h
>
> Linux:
> * Added the hint SDL_HINT_SCREENSAVER_INHIBIT_ACTIVITY_NAME to set the activity that's displayed by the system when the screensaver is disabled
> * Added the hint SDL_HINT_LINUX_JOYSTICK_CLASSIC to control whether /dev/input/js* or /dev/input/event* are used as joystick devices
> * Added the hint SDL_HINT_JOYSTICK_DEVICE to allow the user to specify devices that will be opened in addition to the normal joystick detection
> * Added SDL_LinuxSetThreadPriorityAndPolicy() for more control over a thread priority on Linux
>
>
> Index: Makefile
> ===================================================================
> RCS file: /home/cvs/ports/devel/sdl2/Makefile,v
> retrieving revision 1.37
> diff -u -p -u -p -r1.37 Makefile
> --- Makefile 15 Nov 2021 20:02:05 -0000 1.37
> +++ Makefile 11 Dec 2021 05:40:35 -0000
> @@ -2,14 +2,13 @@
>
> COMMENT= cross-platform multimedia library
>
> -V= 2.0.16
> +V= 2.0.18
> DISTNAME= SDL2-${V}
> PKGNAME= sdl2-${V}
> CATEGORIES= devel
> MASTER_SITES= https://www.libsdl.org/release/
> -REVISION= 0
>
> -SHARED_LIBS= SDL2 0.10 # 0.16
> +SHARED_LIBS= SDL2 0.11 # 0.16
>
> HOMEPAGE= https://www.libsdl.org/
>
> Index: distinfo
> ===================================================================
> RCS file: /home/cvs/ports/devel/sdl2/distinfo,v
> retrieving revision 1.12
> diff -u -p -u -p -r1.12 distinfo
> --- distinfo 20 Aug 2021 16:59:32 -0000 1.12
> +++ distinfo 11 Dec 2021 05:31:32 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (SDL2-2.0.16.tar.gz) = Zb6f9gBANLWyzpkntaTbGBSTDxacSy2uCh5GlwdfKHs=
> -SIZE (SDL2-2.0.16.tar.gz) = 7227262
> +SHA256 (SDL2-2.0.18.tar.gz) = lNQM1z2/oQu26t+8KPNVmSuy1u9nYa2dQHTv+V7lcRw=
> +SIZE (SDL2-2.0.18.tar.gz) = 7294032
> Index: patches/patch-Makefile_in
> ===================================================================
> RCS file: /home/cvs/ports/devel/sdl2/patches/patch-Makefile_in,v
> retrieving revision 1.10
> diff -u -p -u -p -r1.10 patch-Makefile_in
> --- patches/patch-Makefile_in 20 Aug 2021 16:59:32 -0000 1.10
> +++ patches/patch-Makefile_in 11 Dec 2021 05:34:42 -0000
> @@ -3,7 +3,7 @@ $OpenBSD: patch-Makefile_in,v 1.10 2021/
> Index: Makefile.in
> --- Makefile.in.orig
> +++ Makefile.in
> -@@ -132,7 +132,7 @@ LT_AGE = @LT_AGE@
> +@@ -133,7 +133,7 @@ LT_AGE = @LT_AGE@
> LT_CURRENT = @LT_CURRENT@
> LT_RELEASE = @LT_RELEASE@
> LT_REVISION = @LT_REVISION@
> Index: patches/patch-src_SDL_c
> ===================================================================
> RCS file: /home/cvs/ports/devel/sdl2/patches/patch-src_SDL_c,v
> retrieving revision 1.6
> diff -u -p -u -p -r1.6 patch-src_SDL_c
> --- patches/patch-src_SDL_c 20 Aug 2021 16:59:32 -0000 1.6
> +++ patches/patch-src_SDL_c 11 Dec 2021 05:34:40 -0000
> @@ -7,16 +7,17 @@ until OpenBSD support has been rolled ou
> Index: src/SDL.c
> --- src/SDL.c.orig
> +++ src/SDL.c
> -@@ -280,8 +280,6 @@ SDL_InitSubSystem(Uint32 flags)
> - }
> +@@ -295,9 +295,6 @@ SDL_InitSubSystem(Uint32 flags)
> }
> SDL_PrivateSubsystemRefCountIncr(SDL_INIT_HAPTIC);
> + flags_initialized |= SDL_INIT_HAPTIC;
> -#else
> -- return SDL_SetError("SDL not built with haptic (force feedback) support");
> +- SDL_SetError("SDL not built with haptic (force feedback) support");
> +- goto quit_and_error;
>