Saturday, February 05, 2022

Re: [net/tdesktop] enable dbus integration

On Sun, Jan 30, 2022 at 06:08:42PM +0100, Omar Polo wrote:
> Klemens Nanni <kn@openbsd.org> writes:
>
> > Cc'ing all maintainers...
> >
> > On Sun, Jan 30, 2022 at 05:21:45PM +0100, Omar Polo wrote:
> >> As discussed previously, here's a diff to enable the dbus integration
> >> for tdesktop. tested for days on amd64, works fine :)
> >>
> >> I'm particularly interested in this bit because it allows to "use native
> >> notifications" (settings -> notifications -> native notifications.)
> >
> > Understanble, but upstream removed these bits:
> >
> > commit b65d40a22b3dd3ed9cdb8937543f7b6ea53cec3e
> > Author: Ilya Fedin <fedin-ilja2010@ya.ru>
> > Date: Fri Jan 21 20:51:43 2022 +0400
> >
> > Get rid of custom SNI implementation
> >
> > XDG is inventing new tray specification, so SNI will be outdated soon and it's better to just use QSystemTrayIcon.
> > I believe all the major drawbacks of QSystemTrayIcon are solved and we can live with minor ones.
> > Given the planned MainWindow refactoring, it seems it's the best time to do that.
> >
> > Not sure if enabling it now is the best idea.
>
> haven't seen that commit. not in the slightest then
>
> > Can we wait for the next update and go with QSystemTrayIcon or whatever
> > they've come up with?
>
> of course. and sorry for the noise

No worries :)

I just updated tdesktop and enabled dbus integration.

No comments:

Post a Comment