Friday, February 11, 2022

Re: Remove cmake wxneeded hack and set USE_WXNEEDED

On 2022/02/11 21:45, Rafael Sadowski wrote:
> Hi ports!
>
> To work with upstream for a better OpenBSD support I would like to remove
> our deep openbsd hacks in the cmake base-system.
>
> This diff removes the webkit/webengine-wxneeded hack in
> cmComputeLinkInformation.cxx. I added USE_WXNEEDED=Yes in all ports with
> Qt5WebKit and Qt5WebEngine*.
>
> Because the hack handles all "webkit" entries, do we need USE_WXNEEDED in
> all other ports where there is a "webkit"? What are they? www/webkitgtk4?
>
> Feedback?

I don't know exactly what that hack does, but I checked recoll and that
does not currently have an OPENBSD_WXNEEDED section (check with objdump
-p). And for citra you changed from USE_WXNEEDED=Yes to No. So at the
very least there are some missing bumps here, but maybe other changes
are needed too.

No comments:

Post a Comment