On Tue, Feb 08, 2022 at 12:31:39PM +0000, Stuart Henderson wrote:
> On 2022/02/07 22:18, Klemens Nanni wrote:
> > -GH_TAGNAME= release-$V
> > -PKGNAME = gtest-$V
> > +GH_COMMIT= 43efa0a4efd40c78b9210d15373112081899a97c
> > +DISTNAME = gtest-1.11.0.20220207
>
> better with 1.11.0pl20220207 so that if there is another proper release
> it won't need EPOCH
What never version would require EPOCH?
1.11.1, 1.12.0 and 2.0.0 would all be greater than 1.11.0.20220207, no?
So far we've been doing this .<date> version in a few other ports where
none of them use pl<date>.
Am I missing something?
> > +MASTER_SITES0 = https://github.com/google/googletest/commit/
> > +# Fix gtest-help-test failure on OpenBSD
> > +# https://github.com/google/googletest/pull/3751
> > +PATCHFILES = fix-gtest-help-test-{}631f4f99.patch:0
>
> it just touches a couple of lines in one file. why not use a
> normal ports patch?
Less files in-tree and maintaining them is usually easier.
All the patch related work stays in whatever process I do to upstream
them and our ports Makefile just needs the commit id replaced.
No comments:
Post a Comment