Monday, February 07, 2022

Re: UPDATE: gtest 1.11.0 + some patches from upstream

I apologize for the long answer, it's been quite a busy day.

>
>Another thing, upstream won't release further versions and suggest to
>build from the latest commit instead... so I'd fetch from a specific
>commit instead of keeping a long list of PATCHFILES.
>
>cf https://github.com/google/googletest/releases/tag/release-1.11.0
>
>> GoogleTest will not accept patches of new features to v1.11.0.
>> We recommend building GoogleTest from the latest commit instead.
>> Exceptional critical bug fixes may be considered.
>
>FWIW i had the following diff locally (which has to be updated to the
>latest commit) and I can confirm that devel/msgpack and proj still
>builds fine with this and test are passing.

Thanks for testing that!
Yes, your version of the port that uses the actual gtest commit is
much better than the one I suggested. I would be glad if such changes
would be integrated into the port tree.
>
>I'll update it to 14aa11db02d9851d957f93ef9fddb110c1aafdc6 (latest
>commit as of now), cherry pick you fix-gtest-help-test (which is the
>only test failing for me here), do a mini bulk overnight and report back
>how it goes :)
>

Please clarify about the fix-gtest-help-test. I had this test failed
without this patch. According to the code, I have enabled the same
logic for OpenBSD as was already done for Linux,
GNU/kFreeBSD, and hurd.

If you get an error during the test after applying my patch then
please tell me more about it. Maybe I should cancel my pull request
before it is already merged.

Thanks so much for your help!

--
Wbr, Andrew Krasavin

No comments:

Post a Comment