Re: [maintainer update] www/knot, www/py-libknot to 3.1.7

On 4/3/2022 5:41 PM, Jeremie Courreges-Anglas wrote:
> On Wed, Mar 30 2022, aisha <openbsd.ports@aisha.cc> wrote:
>> On 22/03/30 06:27PM, aisha wrote:
>>> Hi,
>>>
>>> Attached patch for update from 3.1.6 to 3.1.7
>>>
>>> New libraries and dependency (brotli*, z, zstd) added due to update of gnutls which propagates here.
>>>
>>> Best,
>>> Aisha
>>>
>> Oops, forgot to add zstd in lib depends.
> No need to add explicit deps on brotli/zstd, those are implicit deps
> from gnutls. If knot did link directly against brotli or zstd it would
> be useful to record them as explicit deps, this is not the case here.
>
> Diff committed without the LIB_DEPENDS change, thanks (sthen@ had
> already synced WANTLIB).
>
> Oh and, please do add me to Cc: next time. I'm not reading ports@ as
> often as I would like to. :)

Will keep in mind for next time!

Thanks,
Aisha

>
>> diff --git a/net/knot/Makefile b/net/knot/Makefile
>> index 7687f8508f9..2339195688e 100644
>> --- a/net/knot/Makefile
>> +++ b/net/knot/Makefile
>> @@ -1,8 +1,7 @@
>> COMMENT = authoritative DNS server
>>
>> # update net/py-libknot when updating this
>> -DISTNAME = knot-3.1.6
>> -REVISION = 1
>> +DISTNAME = knot-3.1.7
>>
>> SHARED_LIBS += dnssec 3.1 # .8.0
>> SHARED_LIBS += knot 7.3 # .12.0
>> @@ -18,9 +17,9 @@ MAINTAINER = Aisha Tammy <openbsd@aisha.cc>, \
>> # GPLv3+
>> PERMIT_PACKAGE = Yes
>>
>> -WANTLIB += c curses edit gmp gnutls hogweed iconv idn2 intl
>> -WANTLIB += lmdb m nettle nghttp2 p11-kit pthread tasn1 unistring urcu
>> -WANTLIB += urcu-common
>> +WANTLIB += brotlidec brotlienc c curses edit gmp gnutls hogweed iconv
>> +WANTLIB += idn2 intl lmdb m nettle nghttp2 p11-kit pthread tasn1
>> +WANTLIB += unistring urcu urcu-common z zstd
>>
>> MASTER_SITES = https://secure.nic.cz/files/knot-dns/
>> EXTRACT_SUFX = .tar.xz
>> @@ -32,7 +31,9 @@ COMPILER = base-clang ports-gcc
>> COMPILER_LANGS = c
>>
>> BUILD_DEPENDS = devel/bison
>> -LIB_DEPENDS = devel/gettext,-runtime \
>> +LIB_DEPENDS = archivers/brotli \
>> + archivers/zstd \
>> + devel/gettext,-runtime \
>> devel/libidn2 \
>> devel/liburcu \
>> security/gnutls \