Thursday, June 30, 2022

graphics/openimageio: actually disable dcmtk

Hi,

(summoning Rafael's cmake-fu)

I spotted an openimageio build error in the current riscv64 bulk:

ninja: error: '/usr/local/lib/libdcmimage.so.0.0', needed by 'lib/libOpenImageIO.so.11.1', missing and no known rule to make it

Setting DCMTK_FOUND=OFF is ineffective (it's not a cached variable /
user setting). With the following diff I can do the follwing dance
without hitting an error.

russell /usr/ports/graphics/openimageio$ make clean; doas pkg_add -a dcmtk; make configure; doas pkg_delete dcmtk; make fake package MAKE_JOBS=2

Since it's possible that a package with an unregistered dep on dcmtk
landed on some user machine, the diff includes a REVISION bump.

ok?

PS: it would be good to audit all the deps and forcefully disable (or
explicitely enable) them if needed.


Index: Makefile
===================================================================
RCS file: /cvs/ports/graphics/openimageio/Makefile,v
retrieving revision 1.62
diff -u -p -r1.62 Makefile
--- Makefile 18 Mar 2022 21:10:59 -0000 1.62
+++ Makefile 30 Jun 2022 13:14:58 -0000
@@ -8,7 +8,7 @@ GH_PROJECT = oiio
GH_TAGNAME = Release-$V
V = 2.2.20.0
DISTNAME = openimageio-${V}
-REVISION = 0
+REVISION = 1

SHARED_LIBS += OpenImageIO 11.1 # 2.2.20
SHARED_LIBS += OpenImageIO_Util 7.0 # 2.2.20
@@ -59,7 +59,7 @@ CONFIGURE_ARGS += -DCMAKE_INSTALL_MANDIR
-DCMAKE_LIBRARY_PATH="${WRKBUILD}/lib:${CMAKE_LIBRARY_PATH}" \
-DSTOP_ON_WARNING=OFF \
-DUSE_CCACHE=OFF \
- -DDCMTK_FOUND=OFF \
+ -DCMAKE_DISABLE_FIND_PACKAGE_DCMTK=TRUE \
-DUSE_EXTERNAL_PUGIXML=ON \
-DUSE_OPENCV=OFF \
-DUSE_OPENVDB=OFF \

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

No comments:

Post a Comment