Re: Mark libime and libmarisa-ruby as broken on sparc64 (Was: sparc64 bulk build report)

Hello,

Yifei Zhan <openbsd@zhan.science> wrote:
> Those 2 packages can't be built on sparc64:
>
> > http://build-failures.rhaalovely.net/sparc64/2022-06-08/inputmethods/libime.log

can't say much about this one

> > http://build-failures.rhaalovely.net/sparc64/2022-06-08/textproc/libmarisa.log

but this one is more interesting:

: marisa-swig_wrap.cxx:2113: error: '__builtin_isfinite' was not
: declared in this scope

but the same version was built on sparc64 for 7.1-RELEASE... it should
work.

I don't see the failure in the bulk build report from May 5 2022, after
that it started to fail with the same error about __builtin_isfinite.

one thing that I don't understand is that AFAICS sparc64 is a llvm arch,
so why it's using (ports) gcc to build this?

: ===> Compiler link: gcc -> /usr/local/bin/egcc
: ===> Compiler link: cc -> /usr/local/bin/egcc
: ===> Compiler link: c++ -> /usr/local/bin/eg++
: ===> Compiler link: g++ -> /usr/local/bin/eg++

maybe needs to be told the compiler? (see patch below, but it's a shot
in the dark)

> libime fails the way as libpinyin. Ruby bind for libmarisa is broken.
>
> I'm not sure how to handle the 'only one subpackage is broken'
> situation, I doubt if the BROKEN- statement support this expression.
> grepping the tree doesn't seem to yield an example, Anyone got an
> idea?
>
> [...]
> +BROKEN-sparc64-ruby = Makefile:230 marisa-swig_wrap.cxx does not compile

that ain't gonna work ;)

the way to do it is to have a PSEUDO_FLAVOR no_ruby to disable the build
of the -ruby subpackage, and automatically enable it on the architectures
where you don't want to build it.

In this case you already have the PSEUDO_FLAVORs to disable the various
subpackages, so all you need to do is something along the lines of

.if ${MACHINE_ARCH} == "sparc64"
FLAVOR += no_ruby
.endif

> COMMENT-main = C++ library for MARISA matching algorithm
> COMMENT-perl = marisa-trie bindings for Perl (SWIG)
> COMMENT-python = marisa-trie bindings for Python (SWIG)
> @@ -11,7 +13,7 @@ PKGNAME-ruby = ruby-libmarisa-${V}
>
> REVISION-main = 1
> REVISION-python = 0
> -REVISION-ruby = 0
> +REVISION-ruby = 1
>
> GH_ACCOUNT = s-yata
> GH_PROJECT = marisa-trie


Index: Makefile
===================================================================
RCS file: /home/cvs/ports/textproc/libmarisa/Makefile,v
retrieving revision 1.5
diff -u -p -r1.5 Makefile
--- Makefile 5 May 2022 15:41:57 -0000 1.5
+++ Makefile 12 Jun 2022 08:06:39 -0000
@@ -9,9 +9,9 @@ PKGNAME-perl = p5-libmarisa-${V}
PKGNAME-python = py3-libmarisa-${V}
PKGNAME-ruby = ruby-libmarisa-${V}

-REVISION-main = 1
-REVISION-python = 0
-REVISION-ruby = 0
+REVISION-main = 2
+REVISION-python = 1
+REVISION-ruby = 1

GH_ACCOUNT = s-yata
GH_PROJECT = marisa-trie
@@ -25,6 +25,8 @@ MAINTAINER = Yifei Zhan <openbsd@zhan.sc

# dual license: either BSD 2-clause or LGPLv2.1+
PERMIT_PACKAGE = Yes
+
+COMPILER = base-clang ports-gcc

PSEUDO_FLAVORS = no_perl no_python no_ruby
FLAVOR? =