Re: new security/libdigidocpp 3.14.8

On Sat, Jun 04, 2022 at 09:19:58AM +0000, Klemens Nanni wrote:
> On Sat, Jun 04, 2022 at 10:06:50AM +0200, Rafael Sadowski wrote:
> > I see:
> >
> > -- Found LibLZMA: /usr/local/lib/liblzma.so.2.1 (found version "5.2.5")
> > CMake Error at /usr/local/share/cmake/Modules/CMakeFindDependencyMacro.cmake:47 (find_package):
> > By not providing "Findzstd.cmake" in CMAKE_MODULE_PATH this project has
> > asked CMake to find a package configuration file provided by "zstd", but
> > CMake did not find one.
> >
> > Could not find a package configuration file provided by "zstd" with any of
> > the following names:
> >
> > zstdConfig.cmake
> > zstd-config.cmake
> >
> > Add the installation prefix of "zstd" to CMAKE_PREFIX_PATH or set
> > "zstd_DIR" to a directory containing one of the above files. If "zstd"
> > provides a separate development package or SDK, be sure it has been
> > installed.
> > Call Stack (most recent call first):
> > /usr/local/lib/cmake/minizip/minizip-config.cmake:30 (find_dependency)
> > CMakeLists.txt:53 (find_package)
>
> Dang, I hacked around this annoying detail so early in the porting
> process that I forgot about it in the end...
>
> So zstd is installed, minizip was and is happy with it, but
> libdigidoc-tool only builds I comment out line 30 like this:
>
> $ grep find_dependency /lib/cmake/minizip/minizip-config.cmake
> 27:find_dependency(ZLIB REQUIRED)
> 28:find_dependency(BZip2 REQUIRED)
> 29:find_dependency(LibLZMA REQUIRED)
> 30:#find_dependency(zstd REQUIRED)
> 31:find_dependency(OpenSSL REQUIRED)
> 32:find_dependency(Iconv REQUIRED)
>
> I looked into this, found no fix, commented the line and finished the
> rest of the port.
>
> Can anyone help me out here?

So libdigidocpp's CMakeLists.txt does

find_package(MiniZip QUIET)
if(UNIX AND NOT APPLE)
find_package(PkgConfig)
pkg_check_modules(MINIZIP minizip IMPORTED_TARGET)
endif()

which means we can force skip minizip-config.cmake and rely on
pkg-config with `CMAKE_DISABLE_FIND_PACKAGE_MiniZip=ON`.

Feedback? OK? (still needs xsd to go in first)