Re: [PATCH] www/nginx: update third-party modules

On 2022/06/08 18:12, Stuart Henderson wrote:
> On 2022/06/08 18:57, Omar Polo wrote:
> > Stuart Henderson <stu@spacehopper.org> wrote:
> > > On 2022/06/07 21:11, Omar Polo wrote:
> > > >
> > > > nginx-lua-1.22.0p0(www/nginx,-lua):
> > > > Missing: luajit-5.1.1 from luajit-2.0.5pl20210608 (/var/www/modules/ngx_http_lua_module.so)
> > > > WANTLIB += luajit-5.1
> > >
> > > it wouldn't be ideal to restrict building nginx to only archs which have luajit
> >
> > openresty/lua-nginx-module upstream moved to luajit from 0.10.16 onward,
> > see for e.g.:
> >
> > https://github.com/openresty/lua-nginx-module/commit/d154e5a7c1cbb7810d0224862e577fc8a6b8e3ac
> >
>
> The luajit 2.0 branch in ports is only for 32-bit arm, amd64, i386, powerpc
> so it misses some important archs.
>
> The upstream 2.1 branch adds arm64 but still not sparc64 and some others.
>
> I think ngx_http_lua_module build will need to be arch-dependent then,
> we don't really want to block nginx build on arm64 and sparc64.
>
> (Looking at https://github.com/openresty/lua-nginx-module it is probably
> also best to fetch github.com/openresty/luajit2 as an additional distfile
> and build with that version instead though that's probably best looked
> at as an extra step later.)
>

Alternatively skip the lua-nginx-module update for now ...

Other issue with that change;

------
RUN_DEPENDS= www/nginx,-main=${VERSION}
RUN_DEPENDS-main= # blank (override default)
-RUN_DEPENDS-lua= ${RUN_DEPENDS} \
- ${_MODLUA_RUN_DEPENDS}
+RUN_DEPENDS-lua= lang/luajit
------

this loses the ${RUN_DEPENDS} i.e. www/nginx,-main=${VERSION} so that
the -lua subpackage no longer depends on nginx