Re: NEW: Nextcloud-24

On 2022/07/01 12:51, Gonzalo L. Rodriguez wrote:
> Hello,
>
> So, this diff is to add Nextcloud 24 and delete 21 which is already EOL.
>
> https://nextcloud.com/changelog/#latest24
>
> OK? Comments?
>
> Cheers.-
>
> --
>
> %gonzalo


: diff -N 21/pkg/PLIST
: --- 21/pkg/PLIST 9 May 2022 15:25:37 -0000 1.11
: +++ /dev/null 1 Jan 1970 00:00:00 -0000
: @@ -1,22017 +0,0 @@
: -@option is-branch
: -@conflict nextcloud-*
: -@pkgpath www/nextcloud
: -@pkgpath www/nextcloud/20
...
: Index: 22/pkg/PLIST
: ===================================================================
: RCS file: /cvs/ports/www/nextcloud/22/pkg/PLIST,v
: retrieving revision 1.12
: diff -u -p -r1.12 PLIST
: --- 22/pkg/PLIST 27 Jun 2022 13:30:43 -0000 1.12
: +++ 22/pkg/PLIST 1 Jul 2022 10:32:29 -0000
: @@ -1,5 +1,7 @@
: @option is-branch
: @conflict nextcloud-*
: +@pkgpath www/nextcloud
: +@pkgpath www/nextcloud/21
: @unexec-delete rm -f ${PREFIX}/conf/modules/httpd-nextcloud.conf
: @unexec-delete rm -f ${PREFIX}/conf/modules/apache-nextcloud.conf
: conf/modules.sample/

You have lost "@pkgpath www/nextcloud/20" in the update

: Index: 24/pkg/PLIST
: ===================================================================
: RCS file: 24/pkg/PLIST
: diff -N 24/pkg/PLIST
: --- /dev/null 1 Jan 1970 00:00:00 -0000
: +++ 24/pkg/PLIST 1 Jul 2022 10:32:31 -0000
: @@ -0,0 +1,22926 @@
: +conf/modules.sample/
: +conf/modules.sample/apache-nextcloud.conf.dist
: +nextcloud/

you miss some annotations, at least some @sample, pkg-readme bits,
@conflict, @option is-branch, maybe others. I suggest "diff 23/pkg/PLIST
24/pkg/PLIST" to find them.