Rafael Sadowski <rafael@sizeofvoid.org> wrote:
> Update dcmtk to 3.6.7. The orthanc update is happy with this version.
>
> OK?
never used dcmtk before but the diff reads fine, usual checks are fine
too, and also the tests:
96% tests passed, 12 tests failed out of 271
the 12 failing tests seems to be network-related.
I've looked at the libs and agree on the major bump too, there are
removed symbols and objects with different sizes all over the place.
fwiw, ok op
nitpick: you could drop NO_TESTS since there is a working regress suite
and also...
> [...]
> +SHARED_LIBS += oflog 1.0 # 3.6
> +SHARED_LIBS += ofstd 1.0 # 3.6
> +SHARED_LIBS += dcmect 0.0 # 3.6
> +SHARED_LIBS += dcmtkcharls 0.0 # 3.6
> +
>
...drop this double blank line. maybe sort SHARED_LIBS too while you're
at it? :)
No comments:
Post a Comment