Re: coturn: specify pidfile and create directory in rc_pre

On 2022/08/05 18:28, Omar Polo wrote:
> Andre Stoebe <as@nul.space> wrote:
> > Hello,
> >
> > turnserver tries to create a pidfile at /var/run/turnserver.pid, but
> > this fails due to permissions. It falls back to /var/tmp/turnserver.pid,
> > so this ends up in /tmp.
>
> which version? are you using some custom flags in /etc/rc.conf.local?
> By any chance, did you enabled(/uncommented) the `pidfile' directive
> in /etc/turnserver.conf?
>
> I'm running 4.5.2p2 on OpenBSD 7.1-STABLE with a minimal config and
> don't see it:
>
> antartica# find / -iname turnserver.pid
> antartica# rcctl check turnserver
> turnserver(ok)
> antartica# pkg_info | grep ^turnserver
> turnserver-4.5.2p2 coturn STUN/TURN server
> antartica# grep pidfile /etc/turnserver.conf
> #pidfile="/var/run/turnserver.pid"
>

also,

-daemon="${TRUEPREFIX}/bin/turnserver --daemon"
+daemon="${TRUEPREFIX}/bin/turnserver --daemon --pidfile=/var/run/turnserver/turnserver.pid"

the "daemon" variable should only be what's _required_ to run it,
something like --pidfile (if it is indeed required) should be in daemon_flags
so it can be overridden