Monday, August 01, 2022

Re: tdesktop: provide qt6 flavour for testing

On Mon, Aug 01, 2022 at 09:01:58AM +0200, Omar Polo wrote:
> Klemens Nanni <kn@openbsd.org> wrote:
> > On Thu, Jun 23, 2022 at 03:57:17PM +0000, Klemens Nanni wrote:
> > > On a simple cwm(1) setup without any DE, I noticed the following
> > > (see net/tdesktop/Makefile r1.31):
> > >
> > > opening videos/pictures worked only once, i.e. clicking on the first
> > > photo after startup would show it in Qt's media viewer, another attempt
> > > would show nothing (video's audio would still be played)
> >
> > I have no idea what changed, but this no longer happens on my exact same
> > setup...
> >
> > The qt6 flavour works as well as the qt5 flavour for me with cwm and so
> > far I've had zero reports about any tdesktop issue whatsoever.
> >
> > Shall we save some build time and use qt6 by default?
> >
> > (Still building over night...)
>
> haven't built with diff below, but i've been using the qt6 flavor since
> it was added and haven't noticed any regression either. (fwiw, using
> cwm too.) I'm happy to see that this workaround is not needed anymore.

Great, maybe it was some bug in Qt6 proper that got fixed with an update
in the meantime.

> ok op for the removal of the qt6 flavor and switching the main package
> to it.
>
> don't we need a @pkgpath in plist to allow updates from tdesktop-qt6 ->
> tdesktop at least?

You mean like this?

> > +@pkgpath net/tdesktop,qt6

No comments:

Post a Comment